openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Dick" <michael.d.d...@gmail.com>
Subject Re: svn commit: r472680 - /incubator/openjpa/trunk/openjpa-project/assembly.xml
Date Thu, 09 Nov 2006 00:00:48 GMT
I'm fine with leaving it in - it shouldn't hold up the release, I just
wanted it noted. I should have mentioned that in the first post.

Better to take the time and get it fixed right rather than hack something in
anyway :-)


On 11/8/06, Marc Prud'hommeaux <mprudhom@apache.org> wrote:
>
>
> Can we live with the "-all-" name for right now? I'm trying to get
> ready to vote on a release, and I've found that playing with that
> stuff can wind up being a lot more time consuming than I always
> expect it to be.
>
>
>
> On Nov 8, 2006, at 3:50 PM, Michael Dick wrote:
>
> > No, I was seeing the same thing. I ended up creating a jar-
> > assembly.xml file
> > which unpacked openjpa-all-${version}.jar to a temp directory then
> > re-jarred
> > it as /target/aggregate/openjpa-${version}.jar. Then I noticed you
> > already
> > fixed the problem.
> >
> > I don't particularly like recreating the jar, but if it'll help I
> > can send a
> > patch of what I had.
> >
> > On 11/8/06, Marc Prud'hommeaux <mprudhom@apache.org> wrote:
> >>
> >>
> >> I'd be happy to have a non "-all" suffixed jar, but without my last
> >> change, I wasn't seeing *any* openjpaXXX.jar file being put into
> >> the .zip package.
> >>
> >> Are you seeing something different?
> >>
> >>
> >> On Nov 8, 2006, at 3:33 PM, Michael Dick wrote:
> >>
> >> > This puts the -all suffix back into the jar name. We took it out in
> >> > OPENJPA-65. It's just a name, might not be a big deal.
> >> >
> >> > I'm not sure if there's a good way to remove the -all suffix. I
> >> > suppose one
> >> > could unpack openjpa-all-${version} and repackage it (I think
> >> > that's what we
> >> > were doing before). It's probably possible to have a script rename
> >> > the jar
> >> > before the zip gets created too, but the timing might get tricky.
> >> >
> >> > Or maybe I'm missing something I've tried it with clean build and
> >> > without
> >> > this time though :-)
> >> > -Mike
> >> >
> >> > On 11/8/06, mprudhom@apache.org <mprudhom@apache.org> wrote:
> >> >>
> >> >> Author: mprudhom
> >> >> Date: Wed Nov  8 14:59:41 2006
> >> >> New Revision: 472680
> >> >>
> >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=472680
> >> >> Log:
> >> >> Manually include the openjpa-all module in the zip file. For some
> >> >> reason,
> >> >> it wasn't being included in the package.
> >> >>
> >> >> Modified:
> >> >>     incubator/openjpa/trunk/openjpa-project/assembly.xml
> >> >>
> >> >> Modified: incubator/openjpa/trunk/openjpa-project/assembly.xml
> >> >> URL:
> >> >> http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-
> >> >> project/assembly.xml?view=diff&rev=472680&r1=472679&r2=472680
> >> >>
> >> >>
> >> =====================================================================
> >> >> =========
> >> >> --- incubator/openjpa/trunk/openjpa-project/assembly.xml
> >> (original)
> >> >> +++ incubator/openjpa/trunk/openjpa-project/assembly.xml Wed
> >> Nov  8
> >> >> 14:59:41 2006
> >> >> @@ -59,6 +59,14 @@
> >> >>      </fileSets>
> >> >>      <dependencySets>
> >> >>          <dependencySet>
> >> >> +            <outputDirectory>/</outputDirectory>
> >> >> +            <unpack>false</unpack>
> >> >> +            <scope>runtime</scope>
> >> >> +            <includes>
> >> >> +                <include>org.apache.openjpa:openjpa-all</include>
> >> >> +            </includes>
> >> >> +        </dependencySet>
> >> >> +        <dependencySet>
> >> >>              <outputDirectory>/lib</outputDirectory>
> >> >>              <unpack>false</unpack>
> >> >>              <scope>runtime</scope>
> >> >>
> >> >>
> >>
> >>
> >
> >
> > --
> > -Michael Dick
>
>


-- 
-Michael Dick

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message