Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 15951 invoked from network); 19 Oct 2006 19:51:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 19 Oct 2006 19:51:04 -0000 Received: (qmail 35254 invoked by uid 500); 19 Oct 2006 19:51:04 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 35231 invoked by uid 500); 19 Oct 2006 19:51:04 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 35222 invoked by uid 99); 19 Oct 2006 19:51:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Oct 2006 12:51:04 -0700 X-ASF-Spam-Status: No, hits=1.9 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of awhite@bea.com designates 63.96.176.25 as permitted sender) Received: from [63.96.176.25] (HELO uslcmh01.bea.com) (63.96.176.25) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Oct 2006 12:51:02 -0700 Received: from [192.168.1.6] ([10.43.242.108]) by uslcmh01.bea.com (Switch-3.2.2/Switch-3.2.2) with ESMTP id k9JJodnW016338 for ; Thu, 19 Oct 2006 15:50:40 -0400 Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <7D856CDFE035FF45A0420ACBD71BDD630243156C@repbex02.amer.bea.com> References: <7D856CDFE035FF45A0420ACBD71BDD630243156C@repbex02.amer.bea.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <728AE190-1629-4C9F-A240-6673F0EC14B7@bea.com> Content-Transfer-Encoding: 7bit From: Abe White Subject: Re: svn commit: r465623 - in /incubator/openjpa/trunk/openjpa-persistence-jdbc/src/test/java/org/apache/openjpa/persistence/generationtype: ./ IdentityGenerationType.java TestGenerationType.java Date: Thu, 19 Oct 2006 12:50:40 -0700 To: open-jpa-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.2) X-PMX-Version: 4.7.1.128075, Antispam-Engine: 2.4.0.264935, Antispam-Data: 2006.10.18.41442 X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N > [ x] Separate setUp() and tearDown() > [ ] Separate setUp() and tearDown(), but setUp() invokes tearDown() > [ ] Typically no tearDown(); put cleanup logic in setUp() > [ ] Other. Please describe. IMO, if we're diligent in writing proper tearDown methods, there's no reason to put the tearDown logic in setUp. The only reason we got into that habit in Kodo was that we were sloppy with our test case cleanup. _______________________________________________________________________ Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.