From open-jpa-dev-return-974-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org Fri Oct 27 19:46:08 2006 Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 97690 invoked from network); 27 Oct 2006 19:46:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Oct 2006 19:46:07 -0000 Received: (qmail 83040 invoked by uid 500); 27 Oct 2006 19:46:18 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 83020 invoked by uid 500); 27 Oct 2006 19:46:18 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 83011 invoked by uid 99); 27 Oct 2006 19:46:18 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Oct 2006 12:46:18 -0700 X-ASF-Spam-Status: No, hits=1.9 required=10.0 tests=DNS_FROM_RFC_ABUSE,DNS_FROM_RFC_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of awhite@bea.com designates 66.248.192.21 as permitted sender) Received: from [66.248.192.21] (HELO usremg01.bea.com) (66.248.192.21) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Oct 2006 12:46:06 -0700 Received: from usremr02.bea.com (usremr02.bea.com [10.160.29.92]) by usremg01.bea.com (Switch-3.2.2/Switch-3.2.2) with ESMTP id k9RJjU5J022067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Fri, 27 Oct 2006 12:45:44 -0700 Received: from [192.168.1.6] ([10.43.243.250]) by usremr02.bea.com (Switch-3.2.2/Switch-3.2.2) with ESMTP id k9RJPss1002639 for ; Fri, 27 Oct 2006 12:25:55 -0700 Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <8A90A8DF-4324-4A95-8FE0-04BFD2E1840E@bea.com> References: <72c1350f0610271102t3b19f95ek29ba5fb433bffdf1@mail.gmail.com> <8A90A8DF-4324-4A95-8FE0-04BFD2E1840E@bea.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <4EF2B3C9-E1B8-42A7-921F-EC46A1BB677F@bea.com> Content-Transfer-Encoding: 7bit From: Abe White Subject: Re: WASTransformer Date: Fri, 27 Oct 2006 12:25:58 -0700 To: open-jpa-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.2) X-PMX-Version: 4.7.1.128075, Antispam-Engine: 2.4.0.264935, Antispam-Data: 2006.10.27.121433 X-PMX-Version: 4.7.1.128075, Antispam-Engine: 2.4.0.264935, Antispam-Data: 2006.9.7.91442 X-Virus-Checked: Checked by ClamAV on apache.org >> +0.5 for moving the logic in to WASManagedRuntime.main(). Go ahead >> and move >> it unless someone objects, there's no real need for another class. > > I went ahead and did this. I also moved WASManagedRuntime's > caching logic to its endConfiguration() callback to avoid the > threading issues that seemed inherent in using delayed caching. > Finally, I made the members of WASManagedRuntime private instead of > protected, just because the rest of the codebase only uses > protected members when a class is meant to be extended. Let me > know if you see problems with any of these changes. One more thing: I removed the logging of errors that are thrown as exceptions. IMO, if you're throwing an exception, you're making it the caller's choice on how to handle it, including whether to log it. That's been our practice throughout the codebase, anyway. Otherwise you tend to wind up with the same errors being recorded many times. _______________________________________________________________________ Notice: This email message, together with any attachments, may contain information of BEA Systems, Inc., its subsidiaries and affiliated entities, that may be confidential, proprietary, copyrighted and/or legally privileged, and is intended solely for the use of the individual or entity named in this message. If you are not the intended recipient, and have received this message in error, please immediately return this by email and then delete it.