Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: open-jpa-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of kwsutter@gmail.com designates
 64.233.184.236 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=j5XxRTXw8vn80KHnK3OmHtHwLLU7+ySAAy9x9fqV46fVD+8ekX++K4sE374jAhUV+2ffQzFrYqE8v5+sXCM9SIQFn9wPbGlYrncyNN7s2RxQ9s6TsVoO+7+zw0TMGVcrXg5DblKivzuazka8ERPMZ0EqRjUbanM6tVzK7Emee6U=
Message-ID: <89c0c52c0608210820y3b87dag790f2641702f2cf9@mail.gmail.com>
Date: Mon, 21 Aug 2006 10:20:27 -0500
From: "Kevin Sutter" <kwsutter@gmail.com>
To: open-jpa-dev@incubator.apache.org
Subject: Re: JIRA bug tracking of code changes
In-Reply-To: <7D856CDFE035FF45A0420ACBD71BDD6301C00B2F@repbex02.amer.bea.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_6146_13349186.1156173627827"
References: <21184631-80A8-413F-A22D-47FE6A29078D@SUN.com>
	 <7D856CDFE035FF45A0420ACBD71BDD6301C00B2F@repbex02.amer.bea.com>

------=_Part_6146_13349186.1156173627827
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

If I am resolving some particular JIRA bug or feature and I come across a
condition like Patrick pointed out...

if (someCondition)
    doSomething;
    doSomethingElse;

I would just fix it as part of the JIRA bug I was already resolving.  No new
JIRA bug, no new paperwork, just resolve the issue.

But, if you come across this type of problem when you are just reviewing the
code, then having some type of "catch all" JIRA bug report might be nice.
But, it's probably not necessary.  Especially since only the approved
committers would have that luxury.  Anybody else would have to submit a
patch.

Kevin

On 8/21/06, Patrick Linskey <plinskey@bea.com> wrote:
>
> > I'm a little more nervous about "things that are wrong" unless we
> > make it clear that it's only things that have no externally visible
> > behavior. These should have real bug numbers and descriptions that
> > users can search.
>
> The problem is that if I stumble across code like this:
>
> if (someCondition)
>     doSomething;
>     doSomethingElse;
>
> I can objectively see that something is wrong, and, depending on the code
> in
> question, can often figure out what the right behavior is. If I need to go
> open a JIRA issue (which in turn means that I'd need to be online) just in
> order to change it, I'm much less likely to make the fix at all. I don't
> like the idea of erecting process barriers to keeping the codebase in good
> shape.
>
> Also, I don't fully buy into the theory that people should be able to see
> all in JIRA. I mean, they do have access to the svn repository, including
> the commit log and 'svn annotate' etc.
>
> Thoughts?
>
> -Patrick
> _______________________________________________________________________
> Notice:  This email message, together with any attachments, may contain
> information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
> entities,  that may be confidential,  proprietary,  copyrighted  and/or
> legally privileged, and is intended solely for the use of the individual
> or entity named in this message. If you are not the intended recipient,
> and have received this message in error, please immediately return this
> by email and then delete it.
>
>
>

------=_Part_6146_13349186.1156173627827--