From open-jpa-dev-return-609-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org Wed Aug 30 14:58:59 2006 Return-Path: Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org Received: (qmail 49699 invoked from network); 30 Aug 2006 14:58:58 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 30 Aug 2006 14:58:58 -0000 Received: (qmail 93027 invoked by uid 500); 30 Aug 2006 14:58:58 -0000 Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org Received: (qmail 92999 invoked by uid 500); 30 Aug 2006 14:58:58 -0000 Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: open-jpa-dev@incubator.apache.org Delivered-To: mailing list open-jpa-dev@incubator.apache.org Received: (qmail 92990 invoked by uid 99); 30 Aug 2006 14:58:58 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2006 07:58:58 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (asf.osuosl.org: local policy) Received: from [66.116.97.229] (HELO mail.dudney.net) (66.116.97.229) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Aug 2006 07:58:57 -0700 Received: from localhost (localhost [127.0.0.1]) by mail.dudney.net (Postfix) with ESMTP id 8BB76316795 for ; Wed, 30 Aug 2006 08:58:45 -0600 (MDT) Received: from mail.dudney.net ([127.0.0.1]) by localhost (mini.dudney.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 07149-04 for ; Wed, 30 Aug 2006 08:58:33 -0600 (MDT) Received: from [192.168.1.101] (c-24-9-189-43.hsd1.co.comcast.net [24.9.189.43]) by mail.dudney.net (Postfix) with ESMTP id 84B11316774 for ; Wed, 30 Aug 2006 08:58:28 -0600 (MDT) Mime-Version: 1.0 (Apple Message framework v752.2) In-Reply-To: <89c0c52c0608300752ocd1ee71p7c22868bffd159bd@mail.gmail.com> References: <89c0c52c0608300707m4967d028y8e0fa5eb67ff4a4c@mail.gmail.com> <74467F1A-31F7-4E62-80C1-195D1BD213A4@apache.org> <89c0c52c0608300752ocd1ee71p7c22868bffd159bd@mail.gmail.com> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <294A96D8-7D72-44B3-845C-CC6D66E224A2@apache.org> Content-Transfer-Encoding: 7bit From: Bill Dudney Subject: Re: Process for Patch verification Date: Wed, 30 Aug 2006 08:58:17 -0600 To: open-jpa-dev@incubator.apache.org X-Mailer: Apple Mail (2.752.2) X-Virus-Scanned: by amavisd-new at dudney.net X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Hi Kevin, Should have known BAU - ah well, can't keep all that in my head... I hope and expect that patches won't be left in JIRA unresolved or unapplied for long periods of time. That would be a major bummer, esp for the poor folk trying to help! Yes forcing the hand would be a good thing IMO :-) TTFN, -bd- On Aug 30, 2006, at 8:52 AM, Kevin Sutter wrote: > Bill, > BAU == Business As Usual > > I guess verifying the patch against the existing set of tests would > be one > way to do it. But, knowing that there are other internal tests > that might > be affected seemed a little harsh. So, I was trying to be more > diplomatic. > I guess it would force the hand to deliver the "failing" tests... :-) > > Kevin > > On 8/30/06, Bill Dudney wrote: >> >> Hi Kevin, >> >> I like the idea of raising awareness of available patches but I don't >> think we want to hold someone up that is doing a bunch of work with >> having to verify all patches that have been submitted and how the >> patches might effect the new work. >> >> One way (I think) to address the concern is to have more than one of >> us apply the patch, run the tests and verify that all tests pass. >> Assuming all tests pass then the patch should be OK and we put a >> comment into the JIRA to that effect. Only problem I can see is that >> some of the internal BEA tests would fail but these tests are on >> their way into the OpenJPA code base correct? >> >> BTW - BAU == ? >> >> TTFN, >> >> -bd- >> >> On Aug 30, 2006, at 8:07 AM, Kevin Sutter wrote: >> >> > Hi, >> > I'm looking to start a conversation on how we can coordinate timely >> > verification of patch submissions. As you have probably noticed, >> > Catalina >> > and I have been working on a patch for OPENJPA-15 ( >> > http://issues.apache.org/jira/browse/OPENJPA-15). Granted, we have >> > had a >> > couple of miscues as we continue to learn the patching and >> > contribution >> > processes. But, we have also had to regenerate the patch a few >> times >> > because of changes being integrated into the affected files before >> > the patch >> > could be verified. >> > >> > I'm wondering if this is BAU in the open-source community, or is >> there >> > something we can do to help this process? >> > >> > I know there was a discussion about having the ability to flag a >> > JIRA report >> > when a patch is attached. I don't believe I've seen resolution of >> > that >> > request. Flagging a JIRA report might help some, but it still >> > doesn't help >> > with a timely verification of the patch. At least it would >> raise the >> > awareness that patches are available for verification. And, any >> > new change >> > activities should check for possible patches before hitting the >> commit >> > button. >> > >> > Since this OpenJPA community is still highly reliant on the >> > original authors >> > of the contribution, I guess this question is mostly directed at >> > them. Once >> > more of us non-BEA committers become familiar enough with the code >> > base, we >> > can help with this verification process to help spread the wealth. >> > But, in >> > the mean time, it would seem that we need to figure out some >> > process for >> > verifying patches before the next set of changes gets committed and >> > makes >> > the patch null-and-void. >> > >> > Thoughts? >> > >> > Kevin >> >>