openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Craig L Russell <Craig.Russ...@Sun.COM>
Subject Re: svn commit: r427472 - in /incubator/openjpa/trunk: openjpa-kernel/src/main/java/org/apache/openjpa/enhance/ openjpa-kernel/src/main/java/org/apache/openjpa/kernel/ openjpa-lib/src/main/java/org/apache/openjpa/lib/jdbc/ openjpa-lib/src/main/java/org/ap
Date Tue, 01 Aug 2006 17:21:24 GMT
Hi Patrick,

Just nit-picking.

The only change that you apparently made to the file was to remove  
the ending newline.

Bygones,

Craig

On Aug 1, 2006, at 9:19 AM, Patrick Linskey wrote:

> Why not? I've never met a Java compiler that doesn't deal with that
> behavior; many of our source files do not end with a newline.
>
> -Patrick
>
> -- 
> Patrick Linskey
> BEA Systems, Inc.
>
>> -----Original Message-----
>> From: Craig.Russell@Sun.COM [mailto:Craig.Russell@Sun.COM]
>> Sent: Tuesday, August 01, 2006 7:50 AM
>> To: open-jpa-dev@incubator.apache.org
>> Subject: Re: svn commit: r427472 - in
>> /incubator/openjpa/trunk:
>> openjpa-kernel/src/main/java/org/apache/openjpa/enhance/
>> openjpa-kernel/src/main/java/org/apache/openjpa/kernel/
>> openjpa-lib/src/main/java/org/apache/openjpa/lib/jdbc/
>> openjpa-lib/src/main/java/org/ap
>>
>> Hi Patrick,
>>
>> So you removed the new line at end of file? Not so good I think...
>>
>> Craig
>>
>> On Aug 1, 2006, at 12:05 AM, pcl@apache.org wrote:
>>
>>> Modified: incubator/openjpa/trunk/openjpa-lib/src/main/java/org/
>>> apache/openjpa/lib/jdbc/DelegatingStatement.java
>>> URL: http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-
>>> lib/src/main/java/org/apache/openjpa/lib/jdbc/
>>> DelegatingStatement.java?rev=427472&r1=427471&r2=427472&view=diff
>>>
>> ===================================================================== 
>> =
>>> ========
>>> --- incubator/openjpa/trunk/openjpa-lib/src/main/java/org/apache/
>>> openjpa/lib/jdbc/DelegatingStatement.java (original)
>>> +++ incubator/openjpa/trunk/openjpa-lib/src/main/java/org/apache/
>>> openjpa/lib/jdbc/DelegatingStatement.java Tue Aug  1
>> 00:05:08 2006 @@
>>> -266,5 +266,4 @@
>>>      public int getResultSetHoldability() throws SQLException {
>>>          throw new UnsupportedOperationException();
>>>      }
>>> -}
>>> -
>>> +}
>>> \ No newline at end of file
>>>
>>
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/ 
>> jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com P.S. A good JDO? O, Gasp!
>>
>>
> ______________________________________________________________________ 
> _
> Notice:  This email message, together with any attachments, may  
> contain
> information  of  BEA Systems,  Inc.,  its subsidiaries  and   
> affiliated
> entities,  that may be confidential,  proprietary,  copyrighted   
> and/or
> legally privileged, and is intended solely for the use of the  
> individual
> or entity named in this message. If you are not the intended  
> recipient,
> and have received this message in error, please immediately return  
> this
> by email and then delete it.

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!


Mime
View raw message