openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Linskey" <plins...@bea.com>
Subject RE: [jira] Updated: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Date Tue, 22 Aug 2006 21:25:57 GMT
(Note that my response here doesn't really answer your question.)

I think that it's good that we've been using JIRA to store information
about changes we're making, but I think it's far more important that we
create test cases that demonstrate the old bad behavior and assert the
new good behavior. That is, I'd like to see us create tests that fail
against the old version of OpenJPA but pass once the patch is applied.

One difficulty with this, of course, is that currently things are set up
so that all tests must pass during a normal compilation. Does anyone
know of a way to designate to mvn that certain tests are expected to
fail, so that we can commit tests that break along with JIRA reports?

-Patrick

-- 
Patrick Linskey
BEA Systems, Inc. 

> -----Original Message-----
> From: Kevin Sutter [mailto:kwsutter@gmail.com] 
> Sent: Tuesday, August 22, 2006 2:21 PM
> To: open-jpa-dev@incubator.apache.org
> Subject: Re: [jira] Updated: (OPENJPA-15) EJBQL grammar needs 
> to be updated to relfect JPA specification
> 
> Now that we have successfully created a patch for OPENJPA-15, 
> what is the
> process for getting this validated and hopefully accepted 
> into SVN?  I have
> been able to verify that the patch can be applied, everything 
> builds, and
> the existing testcases still work.  But, I'm not an expert 
> with the code
> that is being updated, so it would be good for another 
> committer to verify
> the changes.
> 
> Thanks!
> Kevin
> 
> On 8/22/06, Catalina Wei (JIRA) <jira@apache.org> wrote:
> >
> >      [ http://issues.apache.org/jira/browse/OPENJPA-15?page=all ]
> >
> > Catalina Wei updated OPENJPA-15:
> > --------------------------------
> >
> >     Attachment: OPENJPA-15.openjpa-kernel.txt
> >
> > This patch is applied successfully against openjpa-kenel.
> > please ignore the previous attachments.
> >
> > > EJBQL grammar needs to be updated to relfect JPA specification
> > > --------------------------------------------------------------
> > >
> > >                 Key: OPENJPA-15
> > >                 URL: 
> http://issues.apache.org/jira/browse/OPENJPA-15
> > >             Project: OpenJPA
> > >          Issue Type: Bug
> > >          Components: query
> > >            Reporter: David Wisneski
> > >         Assigned To: Catalina Wei
> > >         Attachments: OPENJPA-15.openjpa-kernel.txt, OPENJPA-15.txt
> > >
> > >
> > > when used in subquery, SELECT has different grammar than 
> in top most
> > query.  SELECT NEW is not allowed.  FROM in subuqery has 
> different syntax
> > than in top most query.  For example    "FROM d.employees as e " in
> > subquery where it would be invalid in top query.   
> Expression syntax in
> > HAVING clause needs to allow  "HAVING min(e.salary) > 10 " is
> > valid  provided that e.salary is a grouping field.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the 
> administrators:
> > http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see: 
> http://www.atlassian.com/software/jira
> >
> >
> >
> 
_______________________________________________________________________
Notice:  This email message, together with any attachments, may contain
information  of  BEA Systems,  Inc.,  its subsidiaries  and  affiliated
entities,  that may be confidential,  proprietary,  copyrighted  and/or
legally privileged, and is intended solely for the use of the individual
or entity named in this message. If you are not the intended recipient,
and have received this message in error, please immediately return this
by email and then delete it.

Mime
View raw message