openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Dudney <bdud...@apache.org>
Subject Re: Process for Patch verification
Date Wed, 30 Aug 2006 14:58:17 GMT
Hi Kevin,

Should have known BAU - ah well, can't keep all that in my head...

I hope and expect that patches won't be left in JIRA unresolved or  
unapplied for long periods of time. That would be a major bummer, esp  
for the poor folk trying to help!

Yes forcing the hand would be a good thing IMO :-)

TTFN,

-bd-

On Aug 30, 2006, at 8:52 AM, Kevin Sutter wrote:

> Bill,
> BAU == Business As Usual
>
> I guess verifying the patch against the existing set of tests would  
> be one
> way to do it.  But, knowing that there are other internal tests  
> that might
> be affected seemed a little harsh.  So, I was trying to be more  
> diplomatic.
> I guess it would force the hand to deliver the "failing" tests...  :-)
>
> Kevin
>
> On 8/30/06, Bill Dudney <bdudney@apache.org> wrote:
>>
>> Hi Kevin,
>>
>> I like the idea of raising awareness of available patches but I don't
>> think we want to hold someone up that is doing a bunch of work with
>> having to verify all patches that have been submitted and how the
>> patches might effect the new work.
>>
>> One way (I think) to address the concern is to have more than one of
>> us apply the patch, run the tests and verify that all tests pass.
>> Assuming all tests pass then the patch should be OK and we put a
>> comment into the JIRA to that effect. Only problem I can see is that
>> some of the internal BEA tests would fail but these tests are on
>> their way into the OpenJPA code base correct?
>>
>> BTW - BAU == ?
>>
>> TTFN,
>>
>> -bd-
>>
>> On Aug 30, 2006, at 8:07 AM, Kevin Sutter wrote:
>>
>> > Hi,
>> > I'm looking to start a conversation on how we can coordinate timely
>> > verification of patch submissions.  As you have probably noticed,
>> > Catalina
>> > and I have been working on a patch for OPENJPA-15 (
>> > http://issues.apache.org/jira/browse/OPENJPA-15).  Granted, we have
>> > had a
>> > couple of miscues as we continue to learn the patching and
>> > contribution
>> > processes.  But, we have also had to regenerate the patch a few  
>> times
>> > because of changes being integrated into the affected files before
>> > the patch
>> > could be verified.
>> >
>> > I'm wondering if this is BAU in the open-source community, or is  
>> there
>> > something we can do to help this process?
>> >
>> > I know there was a discussion about having the ability to flag a
>> > JIRA report
>> > when a patch is attached.  I don't believe I've seen resolution of
>> > that
>> > request.  Flagging a JIRA report might help some, but it still
>> > doesn't help
>> > with a timely verification of the patch.  At least it would  
>> raise the
>> > awareness that patches are available for verification.  And, any
>> > new change
>> > activities should check for possible patches before hitting the  
>> commit
>> > button.
>> >
>> > Since this OpenJPA community is still highly reliant on the
>> > original authors
>> > of the contribution, I guess this question is mostly directed at
>> > them.  Once
>> > more of us non-BEA committers become familiar enough with the code
>> > base, we
>> > can help with this verification process to help spread the wealth.
>> > But, in
>> > the mean time, it would seem that we need to figure out some
>> > process for
>> > verifying patches before the next set of changes gets committed and
>> > makes
>> > the patch null-and-void.
>> >
>> > Thoughts?
>> >
>> > Kevin
>>
>>


Mime
View raw message