openjpa-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (OPENJPA-15) EJBQL grammar needs to be updated to relfect JPA specification
Date Sat, 26 Aug 2006 05:06:22 GMT
    [ http://issues.apache.org/jira/browse/OPENJPA-15?page=comments#action_12430697 ] 
            
Craig Russell commented on OPENJPA-15:
--------------------------------------

Thanks very much for contributing this patch. 

My review is a style and readability code review, not necessarily a content code review of
the patch as of Friday 9:50 PM PDT. 

If you were wondering where I got these comments, openjpa does have coding standards borrowed
from Geronimo. The coding standards referenced by our web site has moved to http://cwiki.apache.org/confluence/display/GMOxDEV/Coding+standards
[ I need to update the web site to reflect this.]

1. Tabs are an issue. The convention we agreed to was not to use tabs and to indent 4 spaces
instead.

2. 80 characters are the limit for code lines. Please look at the coding conventions for how
to break lines.

3. if/else statements should use opening and closing braces, even for one line statements.


4. Please use block comments instead of line end comments for multiple line comments.

> EJBQL grammar needs to be updated to relfect JPA specification
> --------------------------------------------------------------
>
>                 Key: OPENJPA-15
>                 URL: http://issues.apache.org/jira/browse/OPENJPA-15
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: query
>            Reporter: David Wisneski
>         Assigned To: Catalina Wei
>         Attachments: openjpa-15.openjpa-kernel.txt
>
>
> when used in subquery, SELECT has different grammar than in top most query.  SELECT NEW
is not allowed.  FROM in subuqery has different syntax than in top most query.  For example
   "FROM d.employees as e " in subquery where it would be invalid in top query.   Expression
syntax in HAVING clause needs to allow  "HAVING min(e.salary) > 10 " is valid  provided
that e.salary is a grouping field.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message