Return-Path: 
 <open-jpa-dev-return-167-apmail-incubator-open-jpa-dev-archive=incubator.apache.org@incubator.apache.org>
Delivered-To: apmail-incubator-open-jpa-dev-archive@locus.apache.org
Received: (qmail 50620 invoked from network); 29 Jul 2006 08:12:15 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur.apache.org with SMTP; 29 Jul 2006 08:12:15 -0000
Received: (qmail 32185 invoked by uid 500); 29 Jul 2006 08:12:15 -0000
Delivered-To: apmail-incubator-open-jpa-dev-archive@incubator.apache.org
Received: (qmail 32158 invoked by uid 500); 29 Jul 2006 08:12:14 -0000
Mailing-List: contact open-jpa-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:open-jpa-dev-help@incubator.apache.org>
List-Unsubscribe: <mailto:open-jpa-dev-unsubscribe@incubator.apache.org>
List-Post: <mailto:open-jpa-dev@incubator.apache.org>
List-Id: <open-jpa-dev.incubator.apache.org>
Reply-To: open-jpa-dev@incubator.apache.org
Delivered-To: mailing list open-jpa-dev@incubator.apache.org
Received: (qmail 32149 invoked by uid 99); 29 Jul 2006 08:12:14 -0000
Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Jul 2006 01:12:14 -0700
X-ASF-Spam-Status: No, hits=0.5 required=10.0
	tests=DNS_FROM_RFC_ABUSE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (asf.osuosl.org: domain of mprudhomapache@gmail.com
 designates 64.233.182.188 as permitted sender)
Received: from [64.233.182.188] (HELO nf-out-0910.google.com) (64.233.182.188)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Jul 2006 01:12:13 -0700
Received: by nf-out-0910.google.com with SMTP id x4so43968nfb
        for <open-jpa-dev@incubator.apache.org>;
 Sat, 29 Jul 2006 01:11:51 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:mime-version:in-reply-to:references:content-type:message-id:content-transfer-encoding:from:subject:date:to:x-mailer:sender;
        b=BRKJESjAOl4LLnDJAAqOO4WKxnoUHYM2DNp2ekDCSalFG0X6OErtg9GeT73kvIsRga4c+xZC5OgQyf0TkOkqPfDeTJg6HmUTciwPWXRaylzf1w3Fkv2FoUZl8p0ppVwvlUNoXrwcV1DKj4Q2WRwveKIKRkLJKV1IuQxHkvruEG0=
Received: by 10.49.29.2 with SMTP id g2mr214015nfj;
        Sat, 29 Jul 2006 01:11:51 -0700 (PDT)
Received: from ?192.168.0.7? ( [82.247.112.136])
        by mx.gmail.com with ESMTP id r33sm5675048nfc.2006.07.29.01.11.50;
        Sat, 29 Jul 2006 01:11:51 -0700 (PDT)
Mime-Version: 1.0 (Apple Message framework v752.2)
In-Reply-To: <7D856CDFE035FF45A0420ACBD71BDD63019CBF22@repbex02.amer.bea.com>
References: <7D856CDFE035FF45A0420ACBD71BDD63019CBF22@repbex02.amer.bea.com>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <324F19CA-BC3F-4A3B-BAE9-651D387CA27F@apache.org>
Content-Transfer-Encoding: 7bit
From: Marc Prud'hommeaux <mprudhom@apache.org>
Subject: Re: RuntimeEnhancement
Date: Sat, 29 Jul 2006 10:11:48 +0200
To: open-jpa-dev@incubator.apache.org
X-Mailer: Apple Mail (2.752.2)
Sender: Marc Prud'hommeaux <mprudhomapache@gmail.com>
X-Virus-Checked: Checked by ClamAV on apache.org
X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N


> Hmm. Does anyone have any idea how to convince mvn to do this as  
> part of
> the build process?

             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-jar-plugin</artifactId>
                 <configuration>
                     <archive>
                         <manifestEntries>
                             <Premain-Class>
                                  
org.apache.openjpa.enhance.PCEnhancerAgent</Premain-Class>
                         </manifestEntries>
                     </archive>
                 </configuration>
             </plugin>

Looking at the META-INF/MANIFEST.MF file in the openjpa- 
kernel-0.9.0.jar file, I do see:

Premain-Class: org.apache.openjpa.enhance.PCEnhancerAgent

... so I think it is being generated and put in the jar as expected.  
However, it should probably be in the openjpa-kernel-5-0.9.0.jar  
file, rather than the openjpa-kernel-0.9.0.jar file (since Premain- 
Class is a Java 5 manifest attribute). So I've gone ahead and changed  
the generation to be in openjpa-kernel-5/pom.xml.

However, I haven't yet tested whether this makes the runtime  
enhancement work as expected.




On Jul 28, 2006, at 10:07 PM, Patrick Linskey wrote:

>> I did some experimentation with runtime enhancement (the doc
>> Marc posted was helpful here).  All the code required is
>> checked in to SVN, but you I did have to add Premain-Class:
>> org.apache.openjpa.enhance.PCEnhancerAgent to the manifest
>> for openjpa-kernel-5-0.9.0.jar.
>
> Hmm. Does anyone have any idea how to convince mvn to do this as  
> part of
> the build process?
>
>> Is this right way to resolve the problem? The documentation
>> refers to org.apache.openjpa.jar which presumably would
>> contain the manifest.
>
> A bunch of the docs were converted via sed scripts; some things  
> (such as
> org.apache.openjpa.jar) are a sad victim of the conversion process.  
> That
> used to be kodo.jar.
>
> In the long run, we need to work out our deployment story. We might  
> want
> to move towards a build system that assembles a monolithic jar out of
> all the modules.
>
>> Admittedly this is a minor issue and I have a workaround, but
>> if I can I'd like to help get the change back into svn.
>
> Probably the most useful things would be to fix the docs to point  
> to the
> right jar, and to divine how to make mvn spit out the right manifest
> info. Theoretically, this might be as easy as some directive or  
> putting
> a MANIFEST.MF file somewhere to get merged during the build  
> process. But
> I'm a mvn newbie, so have no real clue sadly.
>
> -Patrick
> ______________________________________________________________________ 
> _
> Notice:  This email message, together with any attachments, may  
> contain
> information  of  BEA Systems,  Inc.,  its subsidiaries  and   
> affiliated
> entities,  that may be confidential,  proprietary,  copyrighted   
> and/or
> legally privileged, and is intended solely for the use of the  
> individual
> or entity named in this message. If you are not the intended  
> recipient,
> and have received this message in error, please immediately return  
> this
> by email and then delete it.