Return-Path: X-Original-To: apmail-openjpa-commits-archive@www.apache.org Delivered-To: apmail-openjpa-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 04E19FF38 for ; Sat, 11 May 2013 18:55:19 +0000 (UTC) Received: (qmail 96332 invoked by uid 500); 11 May 2013 18:55:19 -0000 Delivered-To: apmail-openjpa-commits-archive@openjpa.apache.org Received: (qmail 96279 invoked by uid 500); 11 May 2013 18:55:18 -0000 Mailing-List: contact commits-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list commits@openjpa.apache.org Received: (qmail 96269 invoked by uid 99); 11 May 2013 18:55:18 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2013 18:55:18 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2013 18:55:16 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id C860523889DA; Sat, 11 May 2013 18:54:56 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1481391 - /openjpa/branches/2.2.1.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java Date: Sat, 11 May 2013 18:54:56 -0000 To: commits@openjpa.apache.org From: jrbauer@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20130511185456.C860523889DA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jrbauer Date: Sat May 11 18:54:56 2013 New Revision: 1481391 URL: http://svn.apache.org/r1481391 Log: Refrain from logging if verifying log factory plugin. Modified: openjpa/branches/2.2.1.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java Modified: openjpa/branches/2.2.1.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java URL: http://svn.apache.org/viewvc/openjpa/branches/2.2.1.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java?rev=1481391&r1=1481390&r2=1481391&view=diff ============================================================================== --- openjpa/branches/2.2.1.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java (original) +++ openjpa/branches/2.2.1.x/openjpa-lib/src/main/java/org/apache/openjpa/lib/conf/PluginValue.java Sat May 11 18:54:56 2013 @@ -20,6 +20,7 @@ package org.apache.openjpa.lib.conf; import org.apache.commons.lang.StringUtils; import org.apache.openjpa.lib.log.Log; +import org.apache.openjpa.lib.log.LogFactory; import org.apache.openjpa.lib.util.Localizer; import org.apache.openjpa.lib.util.ParseException; @@ -106,7 +107,7 @@ public class PluginValue extends ObjectV // ensure plugin value is compatible with plugin type if (obj != null && !type.isAssignableFrom(obj.getClass())) { - Log log = (conf == null) ? null : conf.getConfigurationLog(); + Log log = (conf == null || type.equals(LogFactory.class)) ? null : conf.getConfigurationLog(); String msg = getIncompatiblePluginMessage(obj, type); if (log != null && log.isErrorEnabled()) { log.error(msg);