Return-Path: Delivered-To: apmail-openjpa-commits-archive@www.apache.org Received: (qmail 54629 invoked from network); 15 Jun 2010 02:09:53 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 15 Jun 2010 02:09:53 -0000 Received: (qmail 40635 invoked by uid 500); 15 Jun 2010 02:09:53 -0000 Delivered-To: apmail-openjpa-commits-archive@openjpa.apache.org Received: (qmail 40617 invoked by uid 500); 15 Jun 2010 02:09:52 -0000 Mailing-List: contact commits-help@openjpa.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openjpa.apache.org Delivered-To: mailing list commits@openjpa.apache.org Received: (qmail 40610 invoked by uid 99); 15 Jun 2010 02:09:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jun 2010 02:09:52 +0000 X-ASF-Spam-Status: No, hits=-1361.7 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Jun 2010 02:09:52 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id BF2B62388A3B; Tue, 15 Jun 2010 02:09:06 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r954694 - /openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java Date: Tue, 15 Jun 2010 02:09:06 -0000 To: commits@openjpa.apache.org From: dwoods@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100615020906.BF2B62388A3B@eris.apache.org> Author: dwoods Date: Tue Jun 15 02:09:06 2010 New Revision: 954694 URL: http://svn.apache.org/viewvc?rev=954694&view=rev Log: OPENJPA-1700 FindBugs - Suspicious reference comparison of Boolean values Modified: openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java Modified: openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java?rev=954694&r1=954693&r2=954694&view=diff ============================================================================== --- openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java (original) +++ openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java Tue Jun 15 02:09:06 2010 @@ -46,7 +46,7 @@ public class ResultObjectProviderIterato * Close the underlying result object provider. */ public void close() { - if (_open == Boolean.TRUE) { + if (Boolean.TRUE.equals(_open)) { try { _rop.close(); } catch (Exception e) { @@ -60,7 +60,7 @@ public class ResultObjectProviderIterato } public boolean hasNext() { - if (_open == Boolean.FALSE) + if (Boolean.FALSE.equals(_open)) return false; if (_hasNext == null) {