openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dwo...@apache.org
Subject svn commit: r954694 - /openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
Date Tue, 15 Jun 2010 02:09:06 GMT
Author: dwoods
Date: Tue Jun 15 02:09:06 2010
New Revision: 954694

URL: http://svn.apache.org/viewvc?rev=954694&view=rev
Log:
OPENJPA-1700 FindBugs - Suspicious reference comparison of Boolean values

Modified:
    openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java

Modified: openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java?rev=954694&r1=954693&r2=954694&view=diff
==============================================================================
--- openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
(original)
+++ openjpa/trunk/openjpa-lib/src/main/java/org/apache/openjpa/lib/rop/ResultObjectProviderIterator.java
Tue Jun 15 02:09:06 2010
@@ -46,7 +46,7 @@ public class ResultObjectProviderIterato
      * Close the underlying result object provider.
      */
     public void close() {
-        if (_open == Boolean.TRUE) {
+        if (Boolean.TRUE.equals(_open)) {
             try {
                 _rop.close();
             } catch (Exception e) {
@@ -60,7 +60,7 @@ public class ResultObjectProviderIterato
     }
 
     public boolean hasNext() {
-        if (_open == Boolean.FALSE)
+        if (Boolean.FALSE.equals(_open))
             return false;
 
         if (_hasNext == null) {



Mime
View raw message