openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From allee8...@apache.org
Subject svn commit: r631663 - /openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/AbstractUpdateManager.java
Date Wed, 27 Feb 2008 17:46:02 GMT
Author: allee8285
Date: Wed Feb 27 09:46:00 2008
New Revision: 631663

URL: http://svn.apache.org/viewvc?rev=631663&view=rev
Log:
Potential NPE where custom can be null, Boolean.TRUE or Boolean.FALSE. Follow the pattern
in update() and deleet()

Modified:
    openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/AbstractUpdateManager.java

Modified: openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/AbstractUpdateManager.java
URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/AbstractUpdateManager.java?rev=631663&r1=631662&r2=631663&view=diff
==============================================================================
--- openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/AbstractUpdateManager.java
(original)
+++ openjpa/trunk/openjpa-jdbc/src/main/java/org/apache/openjpa/jdbc/kernel/AbstractUpdateManager.java
Wed Feb 27 09:46:00 2008
@@ -187,7 +187,7 @@
         Boolean custom = mapping.isCustomInsert(sm, store);
         if (!Boolean.FALSE.equals(custom))
             mapping.customInsert(sm, store);
-        if (custom.equals(Boolean.TRUE))
+        if (Boolean.TRUE.equals(custom))
             return;
 
         ClassMapping sup = mapping.getJoinablePCSuperclassMapping();



Mime
View raw message