openjpa-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mprud...@apache.org
Subject svn commit: r501185 - /incubator/openjpa/trunk/openjpa-kernel-5/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
Date Mon, 29 Jan 2007 21:23:13 GMT
Author: mprudhom
Date: Mon Jan 29 13:23:12 2007
New Revision: 501185

URL: http://svn.apache.org/viewvc?view=rev&rev=501185
Log:
Handle ClassNotFoundException and ClassCircularityError instances when trying to load the
classes into the temporary class loader during enhancement. These exceptions will indicate
that the class is not loadable, and so they couldn't have any persistent metadata anyway.

Modified:
    incubator/openjpa/trunk/openjpa-kernel-5/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java

Modified: incubator/openjpa/trunk/openjpa-kernel-5/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
URL: http://svn.apache.org/viewvc/incubator/openjpa/trunk/openjpa-kernel-5/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java?view=diff&rev=501185&r1=501184&r2=501185
==============================================================================
--- incubator/openjpa/trunk/openjpa-kernel-5/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
(original)
+++ incubator/openjpa/trunk/openjpa-kernel-5/src/main/java/org/apache/openjpa/enhance/PCClassFileTransformer.java
Mon Jan 29 13:23:12 2007
@@ -175,11 +175,11 @@
             return null;
         } catch (ClassNotFoundException cnfe) {
             // cannot load the class: this might mean that it is a proxy
-            // or otherwise inaccessible class
+            // or otherwise inaccessible class which can't be an entity
             return Boolean.FALSE;
         } catch (ClassCircularityError cce) {
-            // this can happen if we are loading classes what this
-            // class already depends on
+            // this can happen if we are loading classes that this
+            // class depends on; these will never be enhanced anyway
             return Boolean.FALSE;
         } catch (RuntimeException re) {
             throw re;



Mime
View raw message