Return-Path: Delivered-To: apmail-openejb-dev-archive@www.apache.org Received: (qmail 53748 invoked from network); 9 Oct 2009 20:55:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Oct 2009 20:55:04 -0000 Received: (qmail 48754 invoked by uid 500); 9 Oct 2009 20:55:04 -0000 Delivered-To: apmail-openejb-dev-archive@openejb.apache.org Received: (qmail 48741 invoked by uid 500); 9 Oct 2009 20:55:03 -0000 Mailing-List: contact dev-help@openejb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@openejb.apache.org Delivered-To: mailing list dev@openejb.apache.org Received: (qmail 48731 invoked by uid 99); 9 Oct 2009 20:55:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2009 20:55:03 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of david.blevins@visi.com designates 208.42.176.212 as permitted sender) Received: from [208.42.176.212] (HELO g2host.com) (208.42.176.212) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2009 20:54:52 +0000 Received: from [71.106.81.39] (account dblevins@visi.com HELO [192.168.42.6]) by mailfront1.g2host.com (CommuniGate Pro SMTP 5.1.16) with ESMTPSA id 121007281 for dev@openejb.apache.org; Fri, 09 Oct 2009 15:54:30 -0500 Message-Id: From: David Blevins To: dev@openejb.apache.org In-Reply-To: <25827720.post@talk.nabble.com> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: TR: [jira] Created: (DBCP-297) Ciphered passwords Date: Fri, 9 Oct 2009 13:54:28 -0700 References: <24506359.post@talk.nabble.com> <24787644.post@talk.nabble.com> <25382277.post@talk.nabble.com> <25530357.post@talk.nabble.com> <93A95D00-F44F-4DFD-AC44-1B960AAAE17E@visi.com> <25827720.post@talk.nabble.com> X-Mailer: Apple Mail (2.936) X-Virus-Checked: Checked by ClamAV on apache.org On the PasswordCodec implementation topic, I was thinking we could use a ResourceFinder and format like so for finding the impls - META-INF/org.apache.openejb.resource.jdbc.PasswordCodec/ Where "foo" is a file that contains the name of the class. Then you can just say "foo" instead of the full class name in the tooling and config files. The ResourceFinder is pretty slick and all we need to do to get the impl is this: ResourceFinder finder = new ResourceFinder("META-INF/"); Map impls = finder.mapAllImplementations(PasswordCodec.class); Class fooImpl = impls.get("foo"); -David On Oct 9, 2009, at 1:50 PM, Jean-Louis MONTEIRO wrote: > > Committed revision 823678. > > The current name is "codec". I don't like it so if you have a better > naming, > feel free to change it. > Know, i have to create a page on the wiki for this feature. > > Jean-Louis > > > > David Blevins wrote: >> >> I was looking around for how someone would get this feature to work. >> In the javadoc you mention "In the case you have implemented both >> methods, you can use the PasswordCodec command line tool to encode/ >> decode a password." >> >> What command line tool does this refer to? >> >> Not sure I see how to create the encrypted password. Want to make >> sure we're not missing that part. >> >> -David >> >> On Sep 22, 2009, at 1:10 AM, David Blevins wrote: >> >>> That looks great to me. >>> >>> Minor formatting note, make sure it uses 4 spaces instead of 3. >>> >>> -David >>> >>> >>> On Sep 21, 2009, at 7:53 AM, Jean-Louis MONTEIRO wrote: >>> >>>> >>>> >>>> >>>> David Blevins wrote: >>>>> >>>>> Great feature. I'm fine with where ever it makes sense to put it. >>>>> >>>>> -David >>>>> >>>> >>>> Hey guys, >>>> >>>> I did some enhancements to DBCP integration in order to support >>>> ciphered >>>> passwords. >>>> Before committing something, i would like to get feedback. >>>> >>>> So year is the patch file >>>> http://www.nabble.com/file/p25530357/patch-ciphered-ds.txt >>>> patch-ciphered-ds.txt >>>> >>>> Any feedback is welcome. >>>> Thanks. >>>> >>>> Jean-Louis >>>> -- >>>> View this message in context: >>>> http://www.nabble.com/TR%3A--jira--Created%3A-%28DBCP-297%29-Ciphered-passwords-tp24494802p25530357.html >>>> Sent from the OpenEJB Dev mailing list archive at Nabble.com. >>>> >>>> >>> >>> >> >> >> > > -- > View this message in context: http://www.nabble.com/TR%3A--jira--Created%3A-%28DBCP-297%29-Ciphered-passwords-tp24494802p25827720.html > Sent from the OpenEJB Dev mailing list archive at Nabble.com. > >