openejb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-Louis MONTEIRO <jean-louis.monte...@atosorigin.com>
Subject Re: [VOTE] OpenEJB 3.1.2
Date Tue, 13 Oct 2009 18:52:07 GMT

I didn't run RAT tool.
Mohammad is in charge of this development so i can probably give us more
inputs.
AFAIK, some files are generated but Mohammad changed them after.

This is definitely something i have to tale into account.

Jean-Louis




Jonathan Gallimore-2 wrote:
> 
> I did run RAT (and I'll have another look at the output later) - and saw
> the
> generated files in the list, which I don't think require headers.
> 
> The other files I didn't think required headers as I thought they were
> trivial (a lot of the ejb-jar.xml files just have <ejb-jar/> in them, for
> example).
> 
> Apologies if I've missed something, or got it wrong, I still got a lot to
> learn about the legal side of things.
> 
> Jon
> 
> On Tue, Oct 13, 2009 at 5:51 PM, Kevan Miller
> <kevan.miller@gmail.com>wrote:
> 
>>
>> On Oct 10, 2009, at 7:34 AM, David Blevins wrote:
>>
>>  Ok, we have binaries!
>>>
>>> Repo:
>>>
>>>  https://repository.apache.org/content/repositories/openejb-014
>>>
>>> Binaries:
>>>
>>> 
>>> http://people.apache.org/~dblevins/stage/3.1.2/<http://people.apache.org/%7Edblevins/stage/3.1.2/>
>>>
>>> Branch (to become a tag):
>>>
>>>  http://svn.apache.org/repos/asf/openejb/branches/openejb-3.1.2/
>>>
>>>
>>> And so you can test out the binaries, here's an updated ant script as
>>> usual:
>>>
>>> 
>>> http://people.apache.org/~dblevins/stage/build.xml<http://people.apache.org/%7Edblevins/stage/build.xml>
>>>
>>>  "ant test:all"
>>>
>>> Things look good on osx so far, haven't tried windoze yet.
>>>
>>
>> The NOTICE file copyright date is 2008. It should be 2009.
>>
>> I see a number of source files that are missing apache source license
>> headers. Did anyone run RAT? Some number of these files look like they've
>> been machine generated (e.g.
>> container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/).
>> So, they wouldn't require a license header. A fair number are in the
>> examples. I've appended the list below.
>>
>> May be debatable, but IMO at least some of these should be fixed. Here's
>> my
>> non-binding -1.
>>
>> --kevan
>>
>>  !????? ./assembly/openejb-standalone/src/main/resources/DATA-README.txt
>>  !?????
>> ./assembly/openejb-tomcat/openejb-tomcat-catalina/src/main/resources/META-INF/org.apache.openejb.tomcat/ServerClassLoader
>>  !????? ./container/openejb-core/src/main/resources/default.openejb.conf
>>  !????? ./container/openejb-core/src/main/resources/groups.properties
>>  !????? ./container/openejb-core/src/main/resources/logging.properties
>>  !????? ./container/openejb-core/src/main/resources/login.config
>>  !????? ./container/openejb-core/src/main/resources/users.properties
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.cli/validate.examples
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.cli/validate.help
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/derby
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/hsqldb
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.DataSourcePlugin/idb
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.PasswordCipher/PlainText
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/org.apache.openejb.resource.jdbc.PasswordCipher/Static3DES
>>  !?????
>> ./container/openejb-core/src/main/resources/META-INF/services/org/apache/activemq/broker/openejb
>>  !?????
>> ./container/openejb-core/src/main/resources/schema/ejb-jar_1_1.xsd
>>  !?????
>> ./container/openejb-core/src/test/resources/altddPU1/META-INF/bartest.ejb-jar.xml
>>  !?????
>> ./container/openejb-core/src/test/resources/altddapp1/META-INF/test.ejb-jar.xml
>>  !?????
>> ./container/openejb-core/src/test/resources/altddapp2/META-INF/ejb-jar.xml
>>  !?????
>> ./container/openejb-core/src/test/resources/altddapp2/META-INF/footest.ejb-jar.xml
>>  !?????
>> ./container/openejb-core/src/test/resources/altddapp2/META-INF/test.ejb-jar.xml
>>  !?????
>> ./container/openejb-core/src/test/resources/altddapp2/META-INF/test.env-entries.properties
>>  !?????
>> ./container/openejb-core/src/test/resources/mixedcase/mEta-iNf/ejb-jar.xml
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EAnnotation.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EAttribute.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EClass.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EClassifier.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EDataType.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EEnum.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EEnumLiteral.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EFactory.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EModelElement.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ENamedElement.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EObject.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EOperation.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EPackage.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EParameter.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EReference.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EStringToStringMapEntry.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/EStructuralFeature.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ETypedElement.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/ObjectFactory.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/ecore/package-info.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/ArrayType.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Block.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Comment.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Field.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Initializer.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaClass.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaDataType.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaEvent.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaPackage.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaParameter.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaParameterKind.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/JavaVisibilityKind.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Method.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/ObjectFactory.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/Statement.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/TypeKind.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/java/package-info.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Add.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Any.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Delete.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Difference.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Documentation.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Extension.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Import.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/MetaModel.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Model.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/ObjectFactory.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/PackageReference.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/Replace.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/XMI.java
>>  !?????
>> ./container/openejb-jee/src/main/java/org/apache/openejb/jee/was/v6/xmi/package-info.java
>>  !?????
>> ./container/openejb-jee/src/main/resources/META-INF/schema/xml.xsd
>>  !?????
>> ./container/openejb-spring/src/test/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/alternate-descriptors/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/alternate-descriptors/src/main/resources/META-INF/test.ejb-jar.xml
>>  !?????
>> ./examples/alternate-descriptors/src/test/resources/META-INF/application-client.xml
>>  !?????
>> ./examples/applicationexception/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/component-interfaces/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/custom-injection/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/ear-testing/business-logic/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/helloworld-weblogic/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/injection-of-connectionfactory/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/injection-of-datasource/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/injection-of-ejbs/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/injection-of-entitymanager/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/jpa-eclipselink/src/main/resources/META-INF/ejb-jar.xml
>>  !????? ./examples/jpa-hibernate/src/main/resources/META-INF/ejb-jar.xml
>>  !????? ./examples/simple-cmp2/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-cmp2/src/main/resources/META-INF/openejb-jar.xml
>>  !????? ./examples/simple-mdb/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-mdb-with-descriptor/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-singleton/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-stateful/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-stateless/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-stateless-with-descriptor/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/simple-webservice/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/spring-integration/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/telephone-stateful/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testcase-injection/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testcase-injection/src/test/resources/META-INF/application-client.xml
>>  !?????
>> ./examples/testing-security/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testing-security/src/test/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testing-security-2/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testing-security-2/src/test/resources/groups.properties
>>  !????? ./examples/testing-security-2/src/test/resources/users.properties
>>  !?????
>> ./examples/testing-security-2/src/test/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testing-transactions/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/testing-transactions/src/test/resources/META-INF/ejb-jar.xml
>>  !????? ./examples/webapps/ejb-webservice/client.pl
>>  !????? ./examples/webapps/moviefun/delete-movie.pl
>>  !????? ./examples/webapps/moviefun/get-movies.pl
>>  !?????
>> ./examples/webapps/moviefun/src/main/resources/META-INF/ejb-jar.xml
>>  !????? ./examples/webapps/moviefun/src/main/webapp/default.css
>>  !????? ./examples/webapps/moviefun/src/main/webapp/index.jsp
>>  !????? ./examples/webapps/moviefun/src/main/webapp/setup.jsp
>>  !?????
>> ./examples/webapps/moviefun/src/test/resources/META-INF/application-client.xml
>>  !????? ./examples/webapps/struts/src/main/webapp/prelude.jspf
>>  !?????
>> ./examples/webservice-attachments/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/webservice-security/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/webservice-security/src/main/resources/META-INF/openejb-jar.xml
>>  !?????
>> ./examples/webservice-security/src/test/resources/groups.properties
>>  !?????
>> ./examples/webservice-security/src/test/resources/users.properties
>>  !?????
>> ./examples/webservice-ws-security/src/main/resources/META-INF/CalculatorImplSign-server.properties
>>  !?????
>> ./examples/webservice-ws-security/src/main/resources/META-INF/CalculatorImplUsernameTokenPlainPasswordEncrypt-server.properties
>>  !?????
>> ./examples/webservice-ws-security/src/main/resources/META-INF/ejb-jar.xml
>>  !?????
>> ./examples/webservice-ws-security/src/test/resources/groups.properties
>>  !?????
>> ./examples/webservice-ws-security/src/test/resources/users.properties
>>  !?????
>> ./examples/webservice-ws-security/src/test/resources/META-INF/CalculatorImplSign-client.properties
>>  !?????
>> ./examples/webservice-ws-security/src/test/resources/META-INF/CalculatorImplUsernameTokenPlainPasswordEncrypt-client.properties
>>  !?????
>> ./itests/openejb-itests-client/src/main/resources/META-INF/org.apache.openejb.cli/test.help
>>  !?????
>> ./server/openejb-activemq/src/main/resources/META-INF/org.apache.openejb.server.ServerService/activemq
>>  !?????
>> ./server/openejb-axis/src/main/resources/META-INF/schema/soap_encoding_1_1.xsd
>>  !?????
>> ./server/openejb-client/src/main/resources/META-INF/org.apache.openejb.client.IdentityResolver/jaas
>>  !?????
>> ./server/openejb-client/src/main/resources/META-INF/org.apache.openejb.client.IdentityResolver/simple
>>  !????? ./server/openejb-cxf/src/main/resources/META-INF/cxf.extension
>>  !?????
>> ./server/openejb-cxf/src/main/resources/META-INF/org.apache.openejb.server.ServerService/cxf
>>  !?????
>> ./server/openejb-derbynet/src/main/resources/META-INF/org.apache.openejb.server.ServerService/derbynet
>>  !?????
>> ./server/openejb-ejbd/src/main/resources/META-INF/org.apache.openejb.server.ServerService/ejbd
>>  !?????
>> ./server/openejb-hsql/src/main/resources/META-INF/org.apache.openejb.server.ServerService/hsql
>>  !?????
>> ./server/openejb-http/src/main/resources/META-INF/org.apache.openejb.server.ServerService/httpejbd
>>  !?????
>> ./server/openejb-multicast/src/main/resources/META-INF/org.apache.openejb.server.ServerService/multicast
>>  !?????
>> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/start.examples
>>  !?????
>> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/start.help
>>  !?????
>> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/stop.examples
>>  !?????
>> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.cli/stop.help
>>  !?????
>> ./server/openejb-server/src/main/resources/META-INF/org.apache.openejb.server.ServerService/admin
>>  !?????
>> ./server/openejb-telnet/src/main/resources/META-INF/org.apache.openejb.server.ServerService/telnet
>>  !?????
>> ./server/openejb-webadmin/src/main/resources/META-INF/org.apache.openejb.server.ServerService/webadmin
>>
>>
>>
>>
> 
> 

-- 
View this message in context: http://www.nabble.com/-VOTE--OpenEJB-3.1.2-tp25833260p25878577.html
Sent from the OpenEJB Dev mailing list archive at Nabble.com.


Mime
View raw message