oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lewismc <...@git.apache.org>
Subject [GitHub] oodt pull request: OODT-927 Values passed to SQL commands should b...
Date Thu, 26 May 2016 21:23:56 GMT
GitHub user lewismc opened a pull request:

    https://github.com/apache/oodt/pull/39

    OODT-927 Values passed to SQL commands should be sanitized in CAS DataSourceIngestMapper.java

    Hi Folks,
    This PR 
     * uses prepared statements for SQL queries
     * sanitizes the variable inputs
     * implements try-with-resources if blocks for efficiency which were introduced in Java
7
     * makes commonly used strings static final string constants
     * uses @Override explicitly
     * adds a wee bit of formatting to core/pom.xml so that Tom's formatting job is not buggered.
    
    Generally speaking this cuts down on a alot of code, simplifies things and make it more
modern across the concerned package.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lewismc/oodt master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/oodt/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #39
    
----
commit 1a1cdf1ac8e3dc48187f66923ffd6baa92ced3c3
Author: Lewis John McGibbney <lewis.mcgibbney@gmail.com>
Date:   2016-05-26T21:25:25Z

    OODT-927 Values passed to SQL commands should be sanitized in CAS DataSourceIngestMapper.java

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message