Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9141B18861 for ; Thu, 15 Oct 2015 17:42:28 +0000 (UTC) Received: (qmail 31414 invoked by uid 500); 15 Oct 2015 17:42:28 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 31381 invoked by uid 500); 15 Oct 2015 17:42:28 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Received: (qmail 31363 invoked by uid 99); 15 Oct 2015 17:42:28 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Oct 2015 17:42:28 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 1EC52E1116; Thu, 15 Oct 2015 17:42:28 +0000 (UTC) From: chrismattmann To: dev@oodt.apache.org Reply-To: dev@oodt.apache.org References: In-Reply-To: Subject: [GitHub] oodt pull request: Fix a useless error message with something more... Content-Type: text/plain Message-Id: <20151015174228.1EC52E1116@git1-us-west.apache.org> Date: Thu, 15 Oct 2015 17:42:28 +0000 (UTC) Github user chrismattmann commented on a diff in the pull request: https://github.com/apache/oodt/pull/34#discussion_r42155591 --- Diff: filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java --- @@ -18,30 +18,16 @@ package org.apache.oodt.cas.filemgr.system; //APACHE imports -import org.apache.xmlrpc.WebServer; +import com.google.common.collect.Lists; -//OODT imports -import org.apache.oodt.cas.metadata.Metadata; -import org.apache.oodt.cas.metadata.exceptions.MetExtractionException; -import org.apache.oodt.commons.date.DateUtils; import org.apache.oodt.cas.filemgr.catalog.Catalog; +import org.apache.oodt.cas.filemgr.datatransfer.DataTransfer; +import org.apache.oodt.cas.filemgr.datatransfer.TransferStatusTracker; import org.apache.oodt.cas.filemgr.metadata.ProductMetKeys; import org.apache.oodt.cas.filemgr.metadata.extractors.FilemgrMetExtractor; import org.apache.oodt.cas.filemgr.repository.RepositoryManager; -import org.apache.oodt.cas.filemgr.structs.Element; -import org.apache.oodt.cas.filemgr.structs.ExtractorSpec; -import org.apache.oodt.cas.filemgr.structs.FileTransferStatus; -import org.apache.oodt.cas.filemgr.structs.ProductPage; -import org.apache.oodt.cas.filemgr.structs.ProductType; -import org.apache.oodt.cas.filemgr.structs.Product; -import org.apache.oodt.cas.filemgr.structs.Query; -import org.apache.oodt.cas.filemgr.structs.Reference; -import org.apache.oodt.cas.filemgr.structs.exceptions.CatalogException; -import org.apache.oodt.cas.filemgr.structs.exceptions.QueryFormulationException; -import org.apache.oodt.cas.filemgr.structs.exceptions.RepositoryManagerException; -import org.apache.oodt.cas.filemgr.structs.exceptions.DataTransferException; -import org.apache.oodt.cas.filemgr.structs.exceptions.ValidationLayerException; -import org.apache.oodt.cas.filemgr.structs.exceptions.VersioningException; +import org.apache.oodt.cas.filemgr.structs.*; --- End diff -- please don't use * imports. Please make sure it specifically imports classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---