oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lewis John Mcgibbney <lewis.mcgibb...@gmail.com>
Subject Re: Clover Test Coverage
Date Fri, 16 Oct 2015 17:52:33 GMT
It sure does mate your right.

On Friday, October 16, 2015, Tom Barber <tom.barber@meteorite.bi> wrote:

> Also i terms of product use and acceptance the fact you can demonstrate you
> have a clean tested code base speaks volumes.
> On 16 Oct 2015 18:35, wrote:
>
> > Indeed I think cleaning up what we have and padding out the tests is
> vital
> > for our drive to 1.0
> >
> > Tom
> > On 16 Oct 2015 18:34, "Lewis John Mcgibbney" <lewis.mcgibbney@gmail.com
> <javascript:;>>
> > wrote:
> >
> >> Dynamite Tom. Regardless once one or two of us jump on improving both
> >> sonar
> >> stats and test issues the codebase will be better for it.
> >>
> >>
> >> On Friday, October 16, 2015, Tom Barber <tom.barber@meteorite.bi
> <javascript:;>> wrote:
> >>
> >> >
> >>
> https://builds.apache.org/job/oodt-coverage/13/clover-report/dashboard.html
> >> >
> >> > The rum has worn off, I'm back at work. I did a bit more fiddling and
> >> saw
> >> > you can publish the reports via jenkins, so there you go. Per build
> >> clover
> >> > coverage that you don't need to login to Jenkins for.
> >> >
> >> > Tom
> >> >
> >> > On Fri, Oct 16, 2015 at 12:14 AM, Lewis John Mcgibbney <
> >> > lewis.mcgibbney@gmail.com <javascript:;> <javascript:;>>
wrote:
> >> >
> >> > > Hi Tom,
> >> > > Done. The page is available here
> >> > > http://oodt.apache.org/development.html#testing
> >> > > Ta,
> >> > > Have a good weekend mate.
> >> > >
> >> > > On Thu, Oct 15, 2015 at 4:08 PM, Tom Barber <
> tom.barber@meteorite.bi <javascript:;>
> >> > <javascript:;>>
> >> > > wrote:
> >> > >
> >> > > > Can you do me a favour, I can't find that development page in
CMS
> >> and I
> >> > > > need to drink run,
> >> > > >
> >> > > > change the mvn command to:
> >> > > >
> >> > > > mvn clean
> >> com.atlassian.maven.plugins:maven-clover2-plugin:instrument
> >> > > > com.atlassian.maven.plugins:maven-clover2-plugin:setup
> >> > > > com.atlassian.maven.plugins:maven-clover2-plugin:aggregate
> >> > > > com.atlassian.maven.plugins:maven-clover2-plugin:clover test
> install
> >> > > > -Dmaven.clover.skipGroverJar=true
> >> > > >
> >> > > > and then put if they want to find out more about Clover visit:
> >> > > >
> >> > > >
> >> > >
> >> >
> >>
> https://confluence.atlassian.com/display/CLOVER/Clover-for-Maven+2+and+3+User's+Guide
> >> > > >
> >> > > > Thanks!
> >> > > >
> >> > > > On Fri, Oct 16, 2015 at 12:06 AM, Lewis John Mcgibbney <
> >> > > > lewis.mcgibbney@gmail.com <javascript:;> <javascript:;>>
wrote:
> >> > > >
> >> > > > > bewm
> >> > > > >
> >> > > > > On Thu, Oct 15, 2015 at 4:02 PM, Tom Barber <
> >> tom.barber@meteorite.bi <javascript:;>
> >> > <javascript:;>>
> >> > > > > wrote:
> >> > > > >
> >> > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://builds.apache.org/job/oodt-coverage/ws/target/site/clover/dashboard.html
> >> > > > > >
> >> > > > > > There you go, don't say I don't do anything for ya,
I think it
> >> > might
> >> > > > be a
> >> > > > > > bit up and down over the next few days whilst I clean
it up,
> >> but it
> >> > > > seems
> >> > > > > > to be working fine currently.
> >> > > > > >
> >> > > > > > Tom
> >> > > > > >
> >> > > > > > On Thu, Oct 15, 2015 at 6:11 PM, Lewis John Mcgibbney
<
> >> > > > > > lewis.mcgibbney@gmail.com <javascript:;> <javascript:;>>
> wrote:
> >> > > > > >
> >> > > > > > > Hi Tom.
> >> > > > > > > Thanks for getting this together
> >> > > > > > > http://oodt.apache.org/development.html#testing
> >> > > > > > > Thanks
> >> > > > > > > Lewis
> >> > > > > > >
> >> > > > > > > On Thu, Oct 15, 2015 at 9:47 AM, Tom Barber <
> >> > > tom.barber@meteorite.bi <javascript:;> <javascript:;>
> >> > > > >
> >> > > > > > > wrote:
> >> > > > > > >
> >> > > > > > > > Okay, the build works but it says we have
0% test coverage
> >> > cause
> >> > > > its
> >> > > > > > not
> >> > > > > > > > finding the tests I'll fiddle around with
it later,
> >> > > > > > > >
> >> > > > > > > >
> >> > > > > > > >
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://builds.apache.org/job/oodt-coverage/ws/target/site/clover/dashboard.html
> >> > > > > > > >
> >> > > > > > > > Tom
> >> > > > > > > >
> >> > > > > > > > On Thu, Oct 15, 2015 at 4:20 PM, Lewis John
Mcgibbney <
> >> > > > > > > > lewis.mcgibbney@gmail.com <javascript:;>
<javascript:;>>
> wrote:
> >> > > > > > > >
> >> > > > > > > > > If the output it retained within the
Jenkins job
> workspace
> >> > then
> >> > > > we
> >> > > > > > can
> >> > > > > > > at
> >> > > > > > > > > least look into it.
> >> > > > > > > > > Would be a good point of reference for
developers.
> >> > > > > > > > >
> >> > > > > > > > >
> >> > > > > > > > > On Thursday, October 15, 2015, Tom Barber
<
> >> > > > tom.barber@meteorite.bi <javascript:;> <javascript:;>
> >> > > > > >
> >> > > > > > > > wrote:
> >> > > > > > > > >
> >> > > > > > > > > > Hi Lewis,
> >> > > > > > > > > >
> >> > > > > > > > > > No problem, I thought about adding
it to Jenkins but I
> >> > don't
> >> > > > > think
> >> > > > > > we
> >> > > > > > > > > > publish the site docs automatically
currently, so
> there
> >> is
> >> > > > little
> >> > > > > > > > point.
> >> > > > > > > > > If
> >> > > > > > > > > > someone knows how we can publish
the site docs after
> >> each
> >> > > > build,
> >> > > > > > then
> >> > > > > > > > yes
> >> > > > > > > > > > it would be great to add it to
the jenkins build.
> >> > > > > > > > > >
> >> > > > > > > > > > Tom
> >> > > > > > > > > >
> >> > > > > > > > > > On Thu, Oct 15, 2015 at 4:13 PM,
Lewis John Mcgibbney
> <
> >> > > > > > > > > > lewis.mcgibbney@gmail.com <javascript:;>
> <javascript:;>
> >> <javascript:;>>
> >> > wrote:
> >> > > > > > > > > >
> >> > > > > > > > > > > Nice Tom.
> >> > > > > > > > > > > Will add the directions to
the website documentation
> >> as I
> >> > > > think
> >> > > > > > > there
> >> > > > > > > > > is
> >> > > > > > > > > > an
> >> > > > > > > > > > > area for eat coverage.
> >> > > > > > > > > > > We adding this to the Jenkins
build yes?
> >> > > > > > > > > > >
> >> > > > > > > > > > > On Thursday, October 15, 2015,
Tom Barber <
> >> > > > > > tom.barber@meteorite.bi <javascript:;> <javascript:;>
> >> > > > > > > > > > <javascript:;>> wrote:
> >> > > > > > > > > > >
> >> > > > > > > > > > > > Okay they sent me the
new license, its in our root
> >> > > pom.xml
> >> > > > > but
> >> > > > > > > > > doesn't
> >> > > > > > > > > > > have
> >> > > > > > > > > > > > any effect on the build,
you need to run it
> >> manually:
> >> > > > > > > > > > > >
> >> > > > > > > > > > > > mvn clover2:setup test
clover2:aggregate
> >> clover2:clover
> >> > > > > > > > > > > > -Dmaven.test.failure.ignore=true
> >> > > > > > > > > > > >
> >> > > > > > > > > > > > for example and it will
report to the site folder.
> >> > > > > > > > > > > >
> >> > > > > > > > > > > > The plugin is in the
committers donated licenses
> >> folder
> >> > > in
> >> > > > > SVN,
> >> > > > > > > it
> >> > > > > > > > > is a
> >> > > > > > > > > > > > license for org.apache.*
so if you want to use it
> on
> >> > > > another
> >> > > > > > > > project
> >> > > > > > > > > to
> >> > > > > > > > > > > use
> >> > > > > > > > > > > > the same license.
> >> > > > > > > > > > > >
> >> > > > > > > > > > > > Tom
> >> > > > > > > > > > > >
> >> > > > > > > > > > > > On Thu, Oct 15, 2015
at 6:57 AM, Lewis John
> >> Mcgibbney <
> >> > > > > > > > > > > > lewis.mcgibbney@gmail.com
<javascript:;>
> <javascript:;>
> >> > <javascript:;> <javascript:;>>
> >> > > > > > wrote:
> >> > > > > > > > > > > >
> >> > > > > > > > > > > > > Sound
> >> > > > > > > > > > > > >
> >> > > > > > > > > > > > > On Tue, Oct 13,
2015 at 12:37 PM, Tom Barber <
> >> > > > > > > > > > magicaltrout@apache.org <javascript:;>
> <javascript:;> <javascript:;>
> >> > > > > > > > > > > > <javascript:;>>
> >> > > > > > > > > > > > > wrote:
> >> > > > > > > > > > > > >
> >> > > > > > > > > > > > > > Okay, had a
bit of a search of the mailing
> list
> >> > > archive
> >> > > > > and
> >> > > > > > > > > found a
> >> > > > > > > > > > > > > Clover
> >> > > > > > > > > > > > > > license, so
I added it to the pom, sadly its
> >> out of
> >> > > > date!
> >> > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > I'll check
with Atlassian and see if we can
> get
> >> a
> >> > > > > renewal,
> >> > > > > > > the
> >> > > > > > > > > old
> >> > > > > > > > > > > one
> >> > > > > > > > > > > > > was
> >> > > > > > > > > > > > > > licensed for
all org.apache.* packages so all
> >> > > projects
> >> > > > > > could
> >> > > > > > > > use
> >> > > > > > > > > > it,
> >> > > > > > > > > > > > > > hopefully we
can get another one the same.
> >> > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > Tom
> >> > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > On Sun, Oct
11, 2015 at 9:51 PM, Tom Barber <
> >> > > > > > > > > > tom.barber@meteorite.bi <javascript:;>
> <javascript:;> <javascript:;>
> >> > > > > > > > > > > > <javascript:;>>
> >> > > > > > > > > > > > > > wrote:
> >> > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > > Yeah I
use the clover report all the time in
> >> real
> >> > > > life
> >> > > > > > and
> >> > > > > > > > its
> >> > > > > > > > > > > great
> >> > > > > > > > > > > > > for
> >> > > > > > > > > > > > > > > stuff
like OODT but its an Atlassian
> product,
> >> so
> >> > I
> >> > > > just
> >> > > > > > ran
> >> > > > > > > > it
> >> > > > > > > > > on
> >> > > > > > > > > > > my
> >> > > > > > > > > > > > > > laptop
> >> > > > > > > > > > > > > > > using
my own open source license.
> Technically
> >> we
> >> > > > would
> >> > > > > > > > qualify
> >> > > > > > > > > > for
> >> > > > > > > > > > > an
> >> > > > > > > > > > > > > > open
> >> > > > > > > > > > > > > > > source
license, but I don't know what the
> ASF
> >> > > policy
> >> > > > > is,
> >> > > > > > > or,
> >> > > > > > > > > they
> >> > > > > > > > > > > > might
> >> > > > > > > > > > > > > > > already
have a license in which case,
> >> absolutely,
> >> > > its
> >> > > > > > just
> >> > > > > > > > > > > published
> >> > > > > > > > > > > > > with
> >> > > > > > > > > > > > > > > the standard
Maven Site.
> >> > > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > > If no
one else knows, I can check with
> Infra,
> >> > Sonar
> >> > > > > also
> >> > > > > > is
> >> > > > > > > > > > > supposed
> >> > > > > > > > > > > > to
> >> > > > > > > > > > > > > > > have code
coverage but its not visible so I
> >> don't
> >> > > > know
> >> > > > > if
> >> > > > > > > > they
> >> > > > > > > > > > > > disable
> >> > > > > > > > > > > > > > it,
> >> > > > > > > > > > > > > > > also Clover
reports can be used by Sonar, so
> >> > there
> >> > > is
> >> > > > > > some
> >> > > > > > > > > > > crossover
> >> > > > > > > > > > > > > > there.
> >> > > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > > Tom
> >> > > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > > On Sun,
Oct 11, 2015 at 9:48 PM, Lewis John
> >> > > > Mcgibbney <
> >> > > > > > > > > > > > > > > lewis.mcgibbney@gmail.com
<javascript:;>
> <javascript:;>
> >> > <javascript:;>
> >> > > > > <javascript:;>>
> >> > > > > > > > > wrote:
> >> > > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > >> This
is also extremely useful. How did you
> >> > > generate
> >> > > > > the
> >> > > > > > > > > report?
> >> > > > > > > > > > > Can
> >> > > > > > > > > > > > we
> >> > > > > > > > > > > > > > >> automate
this as part of builds against
> >> master?
> >> > > > > > > > > > > > > > >>
> >> > > > > > > > > > > > > > >> On
Saturday, October 10, 2015, Tom Barber <
> >> > > > > > > > > > > tom.barber@meteorite.bi <javascript:;>
> <javascript:;> <javascript:;>
> >> > > > > > > > > > > > <javascript:;>>
> >> > > > > > > > > > > > > > >> wrote:
> >> > > > > > > > > > > > > > >>
> >> > > > > > > > > > > > > > >> >
On top of the Sonar stuff, I ran
> Atlassian
> >> > > Clover
> >> > > > > over
> >> > > > > > > the
> >> > > > > > > > > > whole
> >> > > > > > > > > > > > > > >> project
to
> >> > > > > > > > > > > > > > >> >
get some coverage stats.
> >> > > > > > > > > > > > > > >> >
> >> > > > > > > > > > > > > > >> >
The results of which you can find here:
> >> > > > > > > > > > > > > > >> >
> http://www.meteorite.bi/downloads/clover/
> >> > > > > > > > > > > > > > >> >
As you can see we currently stand as 26%
> >> > > coverage.
> >> > > > > > > Handily
> >> > > > > > > > > the
> >> > > > > > > > > > > > > clover
> >> > > > > > > > > > > > > > >> >
report tells us some stuff about what's
> >> > missing.
> >> > > > So
> >> > > > > on
> >> > > > > > > top
> >> > > > > > > > > of
> >> > > > > > > > > > > > > cleaning
> >> > > > > > > > > > > > > > >> up
> >> > > > > > > > > > > > > > >> >
the code, I can finally look at adding to
> >> the
> >> > > test
> >> > > > > > > suite.
> >> > > > > > > > > > > > > > >> >
> >> > > > > > > > > > > > > > >> >
Tom
> >> > > > > > > > > > > > > > >> >
> >> > > > > > > > > > > > > > >>
> >> > > > > > > > > > > > > > >>
> >> > > > > > > > > > > > > > >> --
> >> > > > > > > > > > > > > > >> *Lewis*
> >> > > > > > > > > > > > > > >>
> >> > > > > > > > > > > > > > >
> >> > > > > > > > > > > > > > >
> >> > > > > > > > > > > > > >
> >> > > > > > > > > > > > >
> >> > > > > > > > > > > > >
> >> > > > > > > > > > > > >
> >> > > > > > > > > > > > > --
> >> > > > > > > > > > > > > *Lewis*
> >> > > > > > > > > > > > >
> >> > > > > > > > > > > >
> >> > > > > > > > > > >
> >> > > > > > > > > > >
> >> > > > > > > > > > > --
> >> > > > > > > > > > > *Lewis*
> >> > > > > > > > > > >
> >> > > > > > > > > >
> >> > > > > > > > >
> >> > > > > > > > >
> >> > > > > > > > > --
> >> > > > > > > > > *Lewis*
> >> > > > > > > > >
> >> > > > > > > >
> >> > > > > > >
> >> > > > > > >
> >> > > > > > >
> >> > > > > > > --
> >> > > > > > > *Lewis*
> >> > > > > > >
> >> > > > > >
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > > > --
> >> > > > > *Lewis*
> >> > > > >
> >> > > >
> >> > >
> >> > >
> >> > >
> >> > > --
> >> > > *Lewis*
> >> > >
> >> >
> >>
> >>
> >> --
> >> *Lewis*
> >>
> >
>


-- 
*Lewis*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message