oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chrismattmann <...@git.apache.org>
Subject [GitHub] oodt pull request: Fix a useless error message with something more...
Date Thu, 15 Oct 2015 17:42:28 GMT
Github user chrismattmann commented on a diff in the pull request:

    https://github.com/apache/oodt/pull/34#discussion_r42155591
  
    --- Diff: filemgr/src/main/java/org/apache/oodt/cas/filemgr/system/XmlRpcFileManager.java
---
    @@ -18,30 +18,16 @@
     package org.apache.oodt.cas.filemgr.system;
     
     //APACHE imports
    -import org.apache.xmlrpc.WebServer;
    +import com.google.common.collect.Lists;
     
    -//OODT imports
    -import org.apache.oodt.cas.metadata.Metadata;
    -import org.apache.oodt.cas.metadata.exceptions.MetExtractionException;
    -import org.apache.oodt.commons.date.DateUtils;
     import org.apache.oodt.cas.filemgr.catalog.Catalog;
    +import org.apache.oodt.cas.filemgr.datatransfer.DataTransfer;
    +import org.apache.oodt.cas.filemgr.datatransfer.TransferStatusTracker;
     import org.apache.oodt.cas.filemgr.metadata.ProductMetKeys;
     import org.apache.oodt.cas.filemgr.metadata.extractors.FilemgrMetExtractor;
     import org.apache.oodt.cas.filemgr.repository.RepositoryManager;
    -import org.apache.oodt.cas.filemgr.structs.Element;
    -import org.apache.oodt.cas.filemgr.structs.ExtractorSpec;
    -import org.apache.oodt.cas.filemgr.structs.FileTransferStatus;
    -import org.apache.oodt.cas.filemgr.structs.ProductPage;
    -import org.apache.oodt.cas.filemgr.structs.ProductType;
    -import org.apache.oodt.cas.filemgr.structs.Product;
    -import org.apache.oodt.cas.filemgr.structs.Query;
    -import org.apache.oodt.cas.filemgr.structs.Reference;
    -import org.apache.oodt.cas.filemgr.structs.exceptions.CatalogException;
    -import org.apache.oodt.cas.filemgr.structs.exceptions.QueryFormulationException;
    -import org.apache.oodt.cas.filemgr.structs.exceptions.RepositoryManagerException;
    -import org.apache.oodt.cas.filemgr.structs.exceptions.DataTransferException;
    -import org.apache.oodt.cas.filemgr.structs.exceptions.ValidationLayerException;
    -import org.apache.oodt.cas.filemgr.structs.exceptions.VersioningException;
    +import org.apache.oodt.cas.filemgr.structs.*;
    --- End diff --
    
    please don't use * imports. Please make sure it specifically imports classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message