oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lewis John Mcgibbney <lewis.mcgibb...@gmail.com>
Subject Re: Maven POM revamp testing
Date Fri, 25 Sep 2015 20:45:38 GMT
Cool I will track as I need to port it over to the avro_rpc branch anyways.

On Fri, Sep 25, 2015 at 1:44 PM, Chris Mattmann <chris.mattmann@gmail.com>
wrote:

> Can you create a Pull request against master and
> an associated JIRA issue to track and I’ll review?
> If we’re good with at least 1 other person looking
> at this, I’m good (+1) to merge.
>
> —
> Chris Mattmann
> chris.mattmann@gmail.com
>
>
>
>
>
>
> -----Original Message-----
> From: Tom Barber <tom.barber@meteorite.bi>
> Reply-To: <dev@oodt.apache.org>
> Date: Friday, September 25, 2015 at 1:41 PM
> To: "dev@oodt.apache.org" <dev@oodt.apache.org>
> Subject: Maven POM revamp testing
>
> >Okay
> >I would like to push this through pretty quickly because maintaining a
> >massive bunch of poms in line with the trunk is going to be a pain in the
> >balls.
> >
> >So I updated my branch to 0.11 and updates all the poms within that
> >branch, as such all the modules have been standardized on the latest
> >version of a specific dependency, you can find all of that in core/pom.xml
> >
> >I've made a couple of minor changes to the test suite in a couple of
> >modules to make them run on JUnit 4 and also updated slf4j to the latest
> >version to fix a few missmatches and just cause it was bloody ancient.
> >
> >Anyway the build passes.
> >
> >Other than that I have done nothing to the build apart from sort all the
> >poms so the dependencies are easier to grok.
> >
> >Can someone please inform me of what is required to get this signed off
> >and into trunk so I dont have to go through all of this again :)
> >
> >I know one of the things Chris asked about was us importing all the spark
> >stuff again, this shouldn't happen, I haven't changed any imports on the
> >child poms just unified the versions and where they are declared, but to
> >try and offset that fear I did diff the structure of both my branch and
> >the trunk to try and prove there isn't any wild fluctuation in filesize,
> >just the minor differences you'd expect when supplying slightly different
> >dependencies.
> >
> >Tom
> >
> >
> >
>
>
>


-- 
*Lewis*

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message