oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Radu Manole" <manole.v.r...@gmail.com>
Subject Re: Review Request 37705: Full implementation of Avro RPC cas-workflow module.
Date Fri, 04 Sep 2015 14:29:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37705/
-----------------------------------------------------------

(Updated Sept. 4, 2015, 2:29 p.m.)


Review request for oodt, Lewis McGibbney and Chris Mattmann.


Changes
-------

Change the structure of workflow client/server, now it can be configurated in properties file
what implementation should be used.


Repository: oodt


Description
-------

Extracted interfaces from workflow server and client, and created Avro RPC base communication.
Created Avro types for transmision, and a factory that manages trasformation from avro type
to oodt type. Scrips now use Avro rpc.


Diffs (updated)
-----

  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/action/WorkflowMgrStatusUpdate.java
1693501 
  trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr
1693501 
  trunk/mvn/archetypes/radix/src/main/resources/archetype-resources/workflow/src/main/resources/bin/wmgr-client
1693501 
  trunk/pcs/core/src/main/java/org/apache/oodt/pcs/util/WorkflowManagerUtils.java 1693501

  trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1693501 
  trunk/pge/src/test/java/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1693501 
  trunk/webapp/components/src/main/java/org/apache/oodt/cas/webcomponents/workflow/WorkflowMgrConn.java
1693501 
  trunk/workflow/pom.xml 1693501 
  trunk/workflow/src/main/avro/types/AvroWorkflow.avsc PRE-CREATION 
  trunk/workflow/src/main/avro/types/AvroWorkflowCondition.avsc PRE-CREATION 
  trunk/workflow/src/main/avro/types/AvroWorkflowInstance.avsc PRE-CREATION 
  trunk/workflow/src/main/avro/types/AvroWorkflowInstancePage.avsc PRE-CREATION 
  trunk/workflow/src/main/avro/types/AvroWorkflowTask.avsc PRE-CREATION 
  trunk/workflow/src/main/avro/types/protocol.avdl PRE-CREATION 
  trunk/workflow/src/main/bin/wmgr 1693501 
  trunk/workflow/src/main/bin/wmgr-client 1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetFirstPageCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetLastPageCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetNextPageCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetPrevPageCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/GetWorkflowInstsCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/cli/action/WorkflowCliAction.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/BranchRedirector.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/examples/RandomStatusUpdateTask.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/TaskJob.java 1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstancePage.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManager.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/AvroRpcWorkflowManagerClient.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManager.java PRE-CREATION

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClient.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerClientStarter.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/WorkflowManagerStarter.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/AvroRpcWorkflowManagerFactory.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/RpcCommunicationFactory.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/WorkflowManagerFactory.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/rpc/XmlRpcWorkflowManagerFactory.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/tools/InstanceRepoCleaner.java
1693501 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/AvroTypeFactory.java PRE-CREATION

  trunk/workflow/src/main/resources/workflow.properties 1693501 
  trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/TestWorkflowCli.java 1693501

  trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/cli/UseMockClientCmdLineActionStore.java
1693501 
  trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/MockWorkflowManagerClient.java
PRE-CREATION 
  trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestAvroRpcWorkflowManager.java
PRE-CREATION 
  trunk/workflow/src/test/java/org/apache/oodt/cas/workflow/system/TestWorkflowManagerClient.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/37705/diff/


Testing
-------

Uses existing tests and create tests for Avro RPC. Tested Avro type factory. Used user guide
and build and run workflow server, sending an event.


Thanks,

Radu Manole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message