oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Radu Manole" <manole.v.r...@gmail.com>
Subject Review Request 37701: Full Avro RPC impementation in crawler module.
Date Sat, 22 Aug 2015 15:50:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37701/
-----------------------------------------------------------

Review request for oodt, Lewis McGibbney and Chris Mattmann.


Repository: oodt


Description
-------

Modified the DaemonCrawler to use Avro RPC login instead of XML-RPC.


Diffs
-----

  trunk/crawler/pom.xml 1693501 
  trunk/crawler/src/main/avro/types/protocol.avdl PRE-CREATION 
  trunk/crawler/src/main/bin/crawlctl 1693501 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/action/CrawlerLauncherCliAction.java
1693501 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemon.java PRE-CREATION

  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/AvroCrawlDaemonController.java
PRE-CREATION 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemon.java 1693501 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/CrawlDaemonController.java
1693501 
  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/IntCrawlDaemon.java PRE-CREATION

  trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/daemon/IntCrawlDaemonController.java
PRE-CREATION 
  trunk/crawler/src/test/java/org/apache/oodt/cas/crawl/daemon/DummyDaemonCrawler.java PRE-CREATION

  trunk/crawler/src/test/java/org/apache/oodt/cas/crawl/daemon/TestDaemonCrawler.java PRE-CREATION


Diff: https://reviews.apache.org/r/37701/diff/


Testing
-------

No test was found for xmlrpc DaemonCrawler logic, so I made a DummyAvroDaemonCrawler class
to test only the rpc aspect of daemon crawler. 
and created a class TestDaemonCrawler where I tested the connection and the communication
between AvroDaemonCrawler and AvroDaemonCrawlerController.


Thanks,

Radu Manole


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message