Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C53F175ED for ; Sat, 27 Sep 2014 22:35:36 +0000 (UTC) Received: (qmail 46078 invoked by uid 500); 27 Sep 2014 22:35:36 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 46044 invoked by uid 500); 27 Sep 2014 22:35:36 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 40861 invoked by uid 99); 27 Sep 2014 19:31:47 -0000 Content-Type: multipart/alternative; boundary="===============9027093086293128543==" MIME-Version: 1.0 Subject: Re: Review Request 26064: OODT-754 contribute ProdTypePatternMetExtractor From: "Chris Mattmann" To: "Paul Ramirez" , "Shakeh Khudikyan" , "Lewis McGibbney" , "Chris Mattmann" Cc: "oodt" , "Ricky Nguyen" Date: Sat, 27 Sep 2014 19:31:44 -0000 Message-ID: <20140927193144.15006.89736@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Mattmann" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/26064/ X-Sender: "Chris Mattmann" References: <20140926010408.14999.34864@reviews.apache.org> In-Reply-To: <20140926010408.14999.34864@reviews.apache.org> Reply-To: "Chris Mattmann" X-ReviewRequest-Repository: oodt --===============9027093086293128543== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26064/#review54768 ----------------------------------------------------------- Ship it! Please, ship this! Welcome back RickDN :) - Chris Mattmann On Sept. 26, 2014, 1:04 a.m., Ricky Nguyen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26064/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 1:04 a.m.) > > > Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and Shakeh Khudikyan. > > > Bugs: OODT-754 > https://issues.apache.org/jira/browse/OODT-754 > > > Repository: oodt > > > Description > ------- > > This is a cleaned up version of the ProdTypePatternMetExtractor used at one point at CHLA. Wrote some unit tests (and fixed a bug!). Made sure to write some good javadocs and site docs too (they are basically the same as the wiki). > > > Diffs > ----- > > trunk/CHANGES.txt 1627442 > trunk/metadata/pom.xml 1627442 > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/AbstractSAXConfigReader.java PRE-CREATION > trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/ProdTypePatternMetExtractor.java PRE-CREATION > trunk/metadata/src/site/xdoc/user/basic.xml 1627442 > trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestAbstractSAXConfigReader.java PRE-CREATION > trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestProdTypePatternMetExtractor.java PRE-CREATION > trunk/metadata/src/testdata/product-type-patterns-2.xml PRE-CREATION > trunk/metadata/src/testdata/product-type-patterns.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/26064/diff/ > > > Testing > ------- > > 2 test classes, one for the SAX reader and one for the met extractor. > > (1) testExtractMetadata: Sanity check, make sure it works as advertised. > (2) testNewConfigFile: If a second config file is parsed, ignore the first config file. > (3) testElementDeclarationOrder: The order of element declaration is independent of the order of usage in the product-type template. > > > Thanks, > > Ricky Nguyen > > --===============9027093086293128543==--