oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request 26064: OODT-754 contribute ProdTypePatternMetExtractor
Date Sat, 27 Sep 2014 19:31:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26064/#review54768
-----------------------------------------------------------

Ship it!


Please, ship this! Welcome back RickDN :)

- Chris Mattmann


On Sept. 26, 2014, 1:04 a.m., Ricky Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26064/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2014, 1:04 a.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and Shakeh Khudikyan.
> 
> 
> Bugs: OODT-754
>     https://issues.apache.org/jira/browse/OODT-754
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> This is a cleaned up version of the ProdTypePatternMetExtractor used at one point at
CHLA.  Wrote some unit tests (and fixed a bug!).  Made sure to write some good javadocs and
site docs too (they are basically the same as the wiki).
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES.txt 1627442 
>   trunk/metadata/pom.xml 1627442 
>   trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/AbstractSAXConfigReader.java
PRE-CREATION 
>   trunk/metadata/src/main/java/org/apache/oodt/cas/metadata/extractors/ProdTypePatternMetExtractor.java
PRE-CREATION 
>   trunk/metadata/src/site/xdoc/user/basic.xml 1627442 
>   trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestAbstractSAXConfigReader.java
PRE-CREATION 
>   trunk/metadata/src/test/org/apache/oodt/cas/metadata/extractors/TestProdTypePatternMetExtractor.java
PRE-CREATION 
>   trunk/metadata/src/testdata/product-type-patterns-2.xml PRE-CREATION 
>   trunk/metadata/src/testdata/product-type-patterns.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26064/diff/
> 
> 
> Testing
> -------
> 
> 2 test classes, one for the SAX reader and one for the met extractor.
> 
> (1) testExtractMetadata: Sanity check, make sure it works as advertised.
> (2) testNewConfigFile: If a second config file is parsed, ignore the first config file.
> (3) testElementDeclarationOrder: The order of element declaration is independent of the
order of usage in the product-type template.
> 
> 
> Thanks,
> 
> Ricky Nguyen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message