Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oodt.apache.org
Content-Type: multipart/alternative;
 boundary="===============6444628223914561586=="
MIME-Version: 1.0
Subject: Re: Review Request 23870: OODT-685: update the file manager unit
 tests to
 reflect changes in the project directory structure
From: "Ross Laidlaw" <rlaidlaw.open@gmail.com>
To: "Paul Ramirez" <pramirez@jpl.nasa.gov>,
 "Lewis McGibbney" <lewismc@apache.org>,
 "Chris Mattmann" <mattmann@apache.org>
Cc: "Rishi Verma" <riverma@apache.org>,
 "Ross Laidlaw" <rlaidlaw.open@gmail.com>, "oodt" <dev@oodt.apache.org>
Date: Fri, 25 Jul 2014 17:45:46 -0000
Message-ID: <20140725174546.21500.52765@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ross Laidlaw" <noreply@reviews.apache.org>
References: <20140725151622.4204.7753@reviews.apache.org>
In-Reply-To: <20140725151622.4204.7753@reviews.apache.org>
Reply-To: "Ross Laidlaw" <rlaidlaw.open@gmail.com>

--===============6444628223914561586==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On July 25, 2014, 3:16 p.m., Rishi Verma wrote:
> > I call this a success:
> > 
> > BEFORE PATCH:
> > Tests run: 190, Failures: 54, Errors: 13, Skipped: 0 
> > 
> > AFTER PATCH:
> > Tests run: 190, Failures: 1, Errors: 1, Skipped: 0
> > 
> > 
> > The single error and failure is listed below:
> > ===
> > Failed tests: 
> >   testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer): There aren't exactly 4 elements in the test samples! expected:<4> but was:<11>
> > 
> > Tests in error: 
> >   testAddProductType(org.apache.oodt.cas.filemgr.cli.TestFileManagerCli): org.apache.oodt.cas.cli.exception.CmdLineConstructionException: Invalid option: 'typeName'
> > ===
> > 
> > Will need to look more, but Ross, this is a huge step, so great job!

Hi Rishi, thanks for the review!

Lewis and I tried applying this patch (and variations of it) yesterday.  It looked promising at first, and it fixes the majority of tests when run from the filemgr module.  But we found that when running mvn test (or mvn install, etc) from the top level of the project, this patch didn't fix the problem as there were still issues with relative paths.

Lewis was looking into using something like the following, which I think is the recommended way of accessing resources from unit tests:

  URL url = this.getClass().getResource("<path to file within src/test/resources>");
  String filePath = new File(url.getFile()).getAbsolutePath();


So for example, for "src/test/resources/filemgr.properties", the first line above would be:

  URL url = this.getClass().getResource("/filemgr.properties");


I've tried the above in a few unit tests and it seems to work so far.  I'll see if I can get a patch together.


- Ross


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23870/#review48735
-----------------------------------------------------------


On July 23, 2014, 11:33 p.m., Ross Laidlaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23870/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:33 p.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, and Paul Ramirez.
> 
> 
> Bugs: OODT-685
>     https://issues.apache.org/jira/browse/OODT-685
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> After changes in the file manager directory structure for OODT-685, some of the file manager unit tests required updating to point to the new location for test resources (src/testdata moved to src/test/resources).
> 
> This patch updates several of the file manager unit tests that referred to src/testdata to point to src/test/resources instead.
> 
> It also removes duplicate XML from the following test resources in src/test/resources: cmd-line-actions.xml, cmd-line-options.xml and product-types.xml.
> 
> After applying the patch, there are still some issues when running file manager tests (one test error and one test failure), see below for details.
> 
> 
> Diffs
> -----
> 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestMappedDataSourceCatalog.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestOrderedDataSourceCatalog.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/datatransfer/TestLocalDataTransferer.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestCachedIngester.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestLocalCache.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestRmiCache.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestStdIngester.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/structs/type/TestTypeHandler.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManager.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManagerClient.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestExpImpCatalog.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestMetadataBasedProductMover.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestBasicVersioner.java 1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestDateTimeVersioner.java 1612886 
>   /trunk/filemgr/src/test/resources/cmd-line-actions.xml 1612886 
>   /trunk/filemgr/src/test/resources/cmd-line-options.xml 1612886 
>   /trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml 1612886 
> 
> Diff: https://reviews.apache.org/r/23870/diff/
> 
> 
> Testing
> -------
> 
> Before applying the patch, the majority of file manager tests fail, as shown by the results below:
> 
>   Tests run: 189, Failures: 74, Errors: 30, Skipped: 0
> 
> 
> After applying the patch, the majority of file manager tests pass, except for the following (1 failure, 1 error):
> 
>   Results :
> 
>   Failed tests: 
>     testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer): There aren't exactly 4 elements in the test samples! expected:<4> but was:<11>
> 
>   Tests in error: 
>     testAddProductType(org.apache.oodt.cas.filemgr.cli.TestFileManagerCli): org.apache.oodt.cas.cli.exception.CmdLineConstructionException: Invalid option: 'typeName'
> 
> 
> Thanks,
> 
> Ross Laidlaw
> 
>


--===============6444628223914561586==--