oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ross Laidlaw" <rlaidlaw.o...@gmail.com>
Subject Review Request 24140: OODT-723: Fix file manager unit tests in the 'validation' package
Date Thu, 31 Jul 2014 05:32:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24140/
-----------------------------------------------------------

Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and Rishi Verma.


Bugs: OODT-723
    https://issues.apache.org/jira/browse/OODT-723


Repository: oodt


Description
-------

Fixes tests in the 'validation' package for the file manager.  There's a single test class
in the package called TestXMLValidationLayer.  This patch makes a trivial change to the setUp
method so that it can locate the 'vallayer' directory in the src/test/resources area.  There
aren't any System.setProperty() calls in this test class so this is a straightforward fix.


Diffs
-----

  /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java
1614810 

Diff: https://reviews.apache.org/r/24140/diff/


Testing
-------

As described in OODT-722:


The following commands were used to run the tests:

At top-level (trunk directory):

  mvn clean -Dtest=TestXMLValidationLayer -DfailIfNoTests=false test -pl filemgr -am


At module level (filemgr directory):

  mvn clean -Dtest=TestXMLValidationLayer test


Test results before applying the patch:
---------------------------------------

Running org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer
Tests run: 7, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 0.038 sec <<< FAILURE!

Results :

Tests in error: 
  testModifyElement(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testReadProperDescriptionTrimImplicitTrue(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testReadBadFormattedDescriptionTrimImplicitTrue(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testReadDescriptionTrimExplicitFalse(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testReadDescriptionTrimExplicitTrue(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)
  testGetElementsForProductType(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer)

Tests run: 7, Failures: 0, Errors: 7, Skipped: 0


Test results after applying the patch:
--------------------------------------

Running org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer
Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.234 sec

Results :

Tests run: 7, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Ross Laidlaw


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message