oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis McGibbney" <lewi...@apache.org>
Subject Re: Review Request 24060: OODT-721: Fix File Manager Tests - Remove Duplicate XML
Date Thu, 31 Jul 2014 01:25:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24060/#review49192
-----------------------------------------------------------

Ship it!


Ship It!

- Lewis McGibbney


On July 29, 2014, 6:23 p.m., Ross Laidlaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24060/
> -----------------------------------------------------------
> 
> (Updated July 29, 2014, 6:23 p.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, Paul Ramirez, and Rishi Verma.
> 
> 
> Bugs: OODT-721
>     https://issues.apache.org/jira/browse/OODT-721
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> This fix is related to ongoing work on OODT-685.  This change has already been detailed/reviewed
in https://reviews.apache.org/r/23870/ as part of a larger patch.  After discussions on the
mailing lists and in the other reviews, a step-by-step approach has been recommended.  This
patch represents an easy first step - removing duplicate XML from three test resources.  Since
it's a simple change that has already been reviewed, I'll commit it unless there are any objections.
> 
> 
> Diffs
> -----
> 
>   /trunk/filemgr/src/test/resources/cmd-line-actions.xml 1614260 
>   /trunk/filemgr/src/test/resources/cmd-line-options.xml 1614260 
>   /trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml 1614260 
> 
> Diff: https://reviews.apache.org/r/24060/diff/
> 
> 
> Testing
> -------
> 
> Due to other issues that will be addressed in subsequent steps, the file manager tests
still fail after applying this patch.
> 
> 
> Thanks,
> 
> Ross Laidlaw
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message