oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis McGibbney" <lewi...@apache.org>
Subject Re: Review Request 23878: Successor to rlaidlaw reviewboard #23870 for OODT-685
Date Thu, 24 Jul 2014 05:52:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23878/
-----------------------------------------------------------

(Updated July 24, 2014, 5:52 a.m.)


Review request for oodt, Tom Barber, Chris Mattmann, Sean Kelly, Paul Ramirez, Rishi Verma,
Ross Laidlaw, and Tyler Palsulich.


Bugs: OODT-685
    https://issues.apache.org/jira/browse/OODT-685


Repository: oodt


Description
-------

Hi Folks,
OK in the name of staying sane, I am fully behind the decision to just get filemgr back stable.

This review board is somewhat of a successor to @rlaidlaw's patch attached to review board
request - https://reviews.apache.org/r/23870/
Bascially, there is now one failing test (as below) which I cannot debug as it passes for
me locally within my IDE!!!
What is more is that from the command line it actually DOES fail!!! 

Results :

Failed tests:
  testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer): There aren't
exactly 4 elements in the test samples! expected:<4> but was:<11>

Tests run: 190, Failures: 1, Errors: 0, Skipped: 0

>From within my IDE the failing test is located at org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer#testModifyElement,
which DOES NOT fail when I load it from the command line.

I think we should commit these improvements to the filemgr test suite before moving on to
work on maybe upgrading to JUnit 4.11 as per https://issues.apache.org/jira/browse/OODT-687


Diffs
-----

  http://svn.apache.org/repos/asf/oodt/trunk/commons/src/main/java/org/apache/oodt/commons/xml/XMLUtils.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/validation/XMLValidationLayer.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestMappedDataSourceCatalog.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestOrderedDataSourceCatalog.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/datatransfer/TestLocalDataTransferer.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestCachedIngester.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestLocalCache.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestRmiCache.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestStdIngester.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/structs/type/TestTypeHandler.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManager.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManagerClient.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestExpImpCatalog.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestMetadataBasedProductMover.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestBasicVersioner.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestDateTimeVersioner.java
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/cmd-line-actions.xml
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/cmd-line-options.xml
1612972 
  http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml
1612972 

Diff: https://reviews.apache.org/r/23878/diff/


Testing
-------

via command line with following environment variables I get obe failing test as described
above.
Running from within my IDE with same env variables I get a different failing test as described
above.

lmcgibbn@LMC-032857 /usr/local/oodt_685(master) $ mvn -version
Apache Maven 3.2.1 (ea8b2b07643dbb1b84b6d16e1f08391b666bc1e9; 2014-02-14T09:37:52-08:00)
Maven home: /usr/local/apache-maven-3.2.1
Java version: 1.7.0_55, vendor: Oracle Corporation
Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_55.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.9.3", arch: "x86_64", family: "mac"


Thanks,

Lewis McGibbney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message