oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis McGibbney" <lewi...@apache.org>
Subject Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure
Date Wed, 23 Jul 2014 23:52:29 GMT


> On July 23, 2014, 11:50 p.m., Lewis McGibbney wrote:
> > Checked out fresh copy of trunk, applied patch
> > mvn install
> > 
> > Results :
> > 
> > Failed tests:
> >   testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer):
There aren't exactly 4 elements in the test samples! expected:<4> but was:<11>
> > 
> > Tests in error:
> >   testAddProductType(org.apache.oodt.cas.filemgr.cli.TestFileManagerCli): org.apache.oodt.cas.cli.exception.CmdLineConstructionException:
Invalid option: 'typeName'
> > 
> > Tests run: 190, Failures: 1, Errors: 1, Skipped: 0
> > 
> > I seriously think that we should commit this patch as a solution to stabalizing
trunk codebase in filemgr

Additionally, this patch avoid changing too much as it does not pick up test resources from
the /target/test-classes/ directory, it also still loads resources into System calls as oppose
to piping resources to a 'java.util.Property' object however this means that we can change
this at a later stage.
Stabalizing trunk build is the priority here as it is a blocker for releasing 0.7, Ross' patch
here is a good short term solution to fixing this.


- Lewis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23870/#review48576
-----------------------------------------------------------


On July 23, 2014, 11:33 p.m., Ross Laidlaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23870/
> -----------------------------------------------------------
> 
> (Updated July 23, 2014, 11:33 p.m.)
> 
> 
> Review request for oodt, Lewis McGibbney, Chris Mattmann, and Paul Ramirez.
> 
> 
> Bugs: OODT-685
>     https://issues.apache.org/jira/browse/OODT-685
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> After changes in the file manager directory structure for OODT-685, some of the file
manager unit tests required updating to point to the new location for test resources (src/testdata
moved to src/test/resources).
> 
> This patch updates several of the file manager unit tests that referred to src/testdata
to point to src/test/resources instead.
> 
> It also removes duplicate XML from the following test resources in src/test/resources:
cmd-line-actions.xml, cmd-line-options.xml and product-types.xml.
> 
> After applying the patch, there are still some issues when running file manager tests
(one test error and one test failure), see below for details.
> 
> 
> Diffs
> -----
> 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestDataSourceCatalog.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestMappedDataSourceCatalog.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/catalog/TestOrderedDataSourceCatalog.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/cli/TestFileManagerCli.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/datatransfer/TestLocalDataTransferer.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestCachedIngester.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestLocalCache.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestRmiCache.java 1612886

>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/ingest/TestStdIngester.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/repository/TestXMLRepositoryManager.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/structs/type/TestTypeHandler.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManager.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/system/TestXmlRpcFileManagerClient.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestExpImpCatalog.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/tools/TestMetadataBasedProductMover.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/util/TestXmlRpcStructFactory.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/validation/TestXMLValidationLayer.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestBasicVersioner.java
1612886 
>   /trunk/filemgr/src/test/java/org/apache/oodt/cas/filemgr/versioning/TestDateTimeVersioner.java
1612886 
>   /trunk/filemgr/src/test/resources/cmd-line-actions.xml 1612886 
>   /trunk/filemgr/src/test/resources/cmd-line-options.xml 1612886 
>   /trunk/filemgr/src/test/resources/xmlrpc-struct-factory/product-types.xml 1612886 
> 
> Diff: https://reviews.apache.org/r/23870/diff/
> 
> 
> Testing
> -------
> 
> Before applying the patch, the majority of file manager tests fail, as shown by the results
below:
> 
>   Tests run: 189, Failures: 74, Errors: 30, Skipped: 0
> 
> 
> After applying the patch, the majority of file manager tests pass, except for the following
(1 failure, 1 error):
> 
>   Results :
> 
>   Failed tests: 
>     testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValidationLayer): There
aren't exactly 4 elements in the test samples! expected:<4> but was:<11>
> 
>   Tests in error: 
>     testAddProductType(org.apache.oodt.cas.filemgr.cli.TestFileManagerCli): org.apache.oodt.cas.cli.exception.CmdLineConstructionException:
Invalid option: 'typeName'
> 
> 
> Thanks,
> 
> Ross Laidlaw
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message