Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@oodt.apache.org
Content-Type: multipart/alternative;
 boundary="===============0733976753189936808=="
MIME-Version: 1.0
Subject: Re: Review Request 18944: [OODT-669] Disabling resource monitor in
 Assignment monitor feature
From: "Chris Mattmann" <mattmann@apache.org>
To: "Chris Mattmann" <mattmann@apache.org>
Cc: "Rajith Siriwardana" <rajithsiriwardana@gmail.com>,
 "oodt" <dev@oodt.apache.org>
Date: Fri, 02 May 2014 21:20:25 -0000
Message-ID: <20140502212025.17845.56396@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Chris Mattmann" <noreply@reviews.apache.org>
References: <20140309044426.11242.72276@reviews.apache.org>
In-Reply-To: <20140309044426.11242.72276@reviews.apache.org>
Reply-To: "Chris Mattmann" <mattmann@apache.org>

--===============0733976753189936808==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review42060
-----------------------------------------------------------


Rajith, I'm not sure I get this patch. Why do we have to disable the Resource monitor for this to work? We used to have an AssignmentMonitor that didn't need Ganglia up and running -- so we could simply set AssignmentMonitor as the default Monitor and we were good. What's changed?

- Chris Mattmann


On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 4:44 a.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-669
>     https://issues.apache.org/jira/browse/OODT-669
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some re-factored code for assignment monitor 
> 
> 
> Diffs
> -----
> 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java 1575649 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java PRE-CREATION 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java PRE-CREATION 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java 1575649 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java 1575649 
>   trunk/resource/src/main/resources/resource.properties 1575649 
>   trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java PRE-CREATION 
>   trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18944/diff/
> 
> 
> Testing
> -------
> 
> Disabled monitor with Assignment monitor was tested
> 
> 
> Thanks,
> 
> Rajith Siriwardana
> 
>


--===============0733976753189936808==--