oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajith Siriwardana" <rajithsiriward...@gmail.com>
Subject Re: Review Request 18944: [OODT-669] Disabling resource monitor in Assignment monitor feature
Date Sat, 03 May 2014 02:01:28 GMT


> On May 2, 2014, 9:20 p.m., Chris Mattmann wrote:
> > Rajith, I'm not sure I get this patch. Why do we have to disable the Resource monitor
for this to work? We used to have an AssignmentMonitor that didn't need Ganglia up and running
-- so we could simply set AssignmentMonitor as the default Monitor and we were good. What's
changed?

Chris, earlier it was just generating bogus values in the AssignmentMonitor. but now it has
the ability to use a dynamically asigned resource monitor (currenlty we have only Ganglia),
according to [1] disabling Ganglia should happend at that level I guess. AssignmentMonitor
contains things like governing the resource assignments like features so I guess it's a higher
level, dynamic assignment of resource monitor is a level below that. So AssignmentMonitor
to work there should be a ResourceMonitor assigned to it. Correct me if I'm wrong.

[1] https://cwiki.apache.org/confluence/display/OODT/Ganglia+plugin+for+CAS+Resource+Manager


- Rajith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review42060
-----------------------------------------------------------


On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 4:44 a.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-669
>     https://issues.apache.org/jira/browse/OODT-669
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some
re-factored code for assignment monitor 
> 
> 
> Diffs
> -----
> 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java
1575649 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java
PRE-CREATION 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java
PRE-CREATION 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java
1575649 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java
1575649 
>   trunk/resource/src/main/resources/resource.properties 1575649 
>   trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java
PRE-CREATION 
>   trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18944/diff/
> 
> 
> Testing
> -------
> 
> Disabled monitor with Assignment monitor was tested
> 
> 
> Thanks,
> 
> Rajith Siriwardana
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message