oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request 18944: [OODT-669] Disabling resource monitor in Assignment monitor feature
Date Fri, 02 May 2014 21:20:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18944/#review42060
-----------------------------------------------------------


Rajith, I'm not sure I get this patch. Why do we have to disable the Resource monitor for
this to work? We used to have an AssignmentMonitor that didn't need Ganglia up and running
-- so we could simply set AssignmentMonitor as the default Monitor and we were good. What's
changed?

- Chris Mattmann


On March 9, 2014, 4:44 a.m., Rajith Siriwardana wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18944/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 4:44 a.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-669
>     https://issues.apache.org/jira/browse/OODT-669
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> Patch contains disabling Resource Monitor feature in Assignment Monitor and also some
re-factored code for assignment monitor 
> 
> 
> Diffs
> -----
> 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/AssignmentMonitor.java
1575649 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitor.java
PRE-CREATION 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/disabledmonitor/DisabledResourceMonitorFactory.java
PRE-CREATION 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaAdapter.java
1575649 
>   trunk/resource/src/main/java/org/apache/oodt/cas/resource/monitor/ganglia/GangliaResourceMonitor.java
1575649 
>   trunk/resource/src/main/resources/resource.properties 1575649 
>   trunk/resource/src/test/org/apache/oodt/cas/resource/monitor/TestAssignmentMonWithNoResourceMon.java
PRE-CREATION 
>   trunk/resource/src/testdata/test.disabledmon.resource.properties PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/18944/diff/
> 
> 
> Testing
> -------
> 
> Disabled monitor with Assignment monitor was tested
> 
> 
> Thanks,
> 
> Rajith Siriwardana
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message