Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E6EB810146 for ; Sat, 21 Dec 2013 06:32:17 +0000 (UTC) Received: (qmail 8638 invoked by uid 500); 21 Dec 2013 06:32:17 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 8549 invoked by uid 500); 21 Dec 2013 06:32:15 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 6808 invoked by uid 99); 20 Dec 2013 06:15:44 -0000 Content-Type: multipart/alternative; boundary="===============2450503600509815496==" MIME-Version: 1.0 Subject: Re: Review Request 15936: OODT 563 - a) Modifying Workflow Manager to allow adding new workflows From: "Chris Mattmann" To: "Chris Mattmann" Cc: "oodt" , "Varun Ratnakar" Date: Fri, 20 Dec 2013 06:15:42 -0000 Message-ID: <20131220061542.16721.61695@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Mattmann" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/15936/ X-Sender: "Chris Mattmann" References: <20131201185426.12838.36010@reviews.apache.org> In-Reply-To: <20131201185426.12838.36010@reviews.apache.org> Reply-To: "Chris Mattmann" X-ReviewRequest-Repository: oodt --===============2450503600509815496== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15936/#review30736 ----------------------------------------------------------- trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java why wouldn't it be a PC workflow here? trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java nice catch! - Chris Mattmann On Dec. 1, 2013, 6:54 p.m., Varun Ratnakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15936/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2013, 6:54 p.m.) > > > Review request for oodt and Chris Mattmann. > > > Bugs: OODT-563 > https://issues.apache.org/jira/browse/OODT-563 > > > Repository: oodt > > > Description > ------- > > This patch addresses a part of https://issues.apache.org/jira/browse/OODT-563. It provides: > > 1. Additions to XmlRpcWorkflowManager(Client) to refreshRepository (i.e. reload repository) > 2. Modifications to PackagedWorkflowRepository's addWorkflow function to properly deal with added workflows > > > Diffs > ----- > > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/repository/PackagedWorkflowRepository.java 1546774 > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1546774 > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManagerClient.java 1546774 > > Diff: https://reviews.apache.org/r/15936/diff/ > > > Testing > ------- > > > Thanks, > > Varun Ratnakar > > --===============2450503600509815496==--