Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B730103E8 for ; Fri, 20 Dec 2013 06:12:35 +0000 (UTC) Received: (qmail 2494 invoked by uid 500); 20 Dec 2013 06:12:34 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 2441 invoked by uid 500); 20 Dec 2013 06:12:29 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 1937 invoked by uid 99); 20 Dec 2013 06:11:15 -0000 Content-Type: multipart/alternative; boundary="===============1146236564131865502==" MIME-Version: 1.0 Subject: Re: Review Request 15937: OODT 563 - b) New webapp: cas-wm-services (Workflow Manager Services) to allow adding/removing workflows From: "Chris Mattmann" To: "Chris Mattmann" Cc: "oodt" , "Varun Ratnakar" Date: Fri, 20 Dec 2013 06:10:59 -0000 Message-ID: <20131220061059.16721.5868@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Mattmann" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/15937/ X-Sender: "Chris Mattmann" References: <20131201190058.12847.57843@reviews.apache.org> In-Reply-To: <20131201190058.12847.57843@reviews.apache.org> Reply-To: "Chris Mattmann" X-ReviewRequest-Repository: oodt --===============1146236564131865502== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15937/#review30735 ----------------------------------------------------------- trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/repository/PackagedWorkflowManager.java ALv2 header trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/repository/PackagedWorkflowManager.java I don't get what the point of this class is -- it seems to replicate functionality from the PackagedWorkflowRepository -- can you elaborate? trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/Resource.java ALv2 header trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/Resource.java is this a base class for WMresource services? If so I think it should have a more explicit name -- like AbstractWorkflowResource or something like that and then I think the methods should be protected. trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowResource.java this should call the actual PackagedWorkflowRepository (since it's a read only operation). trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowResource.java would be great to add this read only method to packaged workflow repo in WM. trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/servlets/WmServicesServlet.java seems like at some level, this class shouldn't be needed, and that the config here should be moved to AbstractWorkflowResource? trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml how about /wmservices? trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml should be [WORKFLOW_URL] and envReplaced. trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml should be replaced with [WORKFLOW_HOME]/policy/wengine, and then inside of AbstractWorkflowResource should be PathUtils.envReplaced (all read context params) - Chris Mattmann On Dec. 1, 2013, 7 p.m., Varun Ratnakar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15937/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2013, 7 p.m.) > > > Review request for oodt and Chris Mattmann. > > > Bugs: OODT-563 > https://issues.apache.org/jira/browse/OODT-563 > > > Repository: oodt > > > Description > ------- > > This patch addresses the second part of https://issues.apache.org/jira/browse/OODT-563. It adds a new webapp under webapps/wmservices which provides: > 1. A servlet with Jax-RS functionality to Add/Remove workflows (just packaged repository workflows for now) > > > Diffs > ----- > > trunk/webapp/wmservices/pom.xml PRE-CREATION > trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/client/WmServicesClient.java PRE-CREATION > trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/repository/PackagedWorkflowManager.java PRE-CREATION > trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/Resource.java PRE-CREATION > trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowResource.java PRE-CREATION > trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/servlets/WmServicesServlet.java PRE-CREATION > trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml PRE-CREATION > trunk/webapp/wmservices/src/main/webapp/WEB-INF/web.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/15937/diff/ > > > Testing > ------- > > > Thanks, > > Varun Ratnakar > > --===============1146236564131865502==--