oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request 15937: OODT 563 - b) New webapp: cas-wm-services (Workflow Manager Services) to allow adding/removing workflows
Date Fri, 20 Dec 2013 06:10:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15937/#review30735
-----------------------------------------------------------



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/repository/PackagedWorkflowManager.java
<https://reviews.apache.org/r/15937/#comment58831>

    ALv2 header



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/repository/PackagedWorkflowManager.java
<https://reviews.apache.org/r/15937/#comment58832>

    I don't get what the point of this class is -- it seems to replicate functionality from
the PackagedWorkflowRepository -- can you elaborate?



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/Resource.java
<https://reviews.apache.org/r/15937/#comment58833>

    ALv2 header



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/Resource.java
<https://reviews.apache.org/r/15937/#comment58834>

    is this a base class for WMresource services? If so I think it should have a more explicit
name -- like AbstractWorkflowResource or something like that and then I think the methods
should be protected.



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowResource.java
<https://reviews.apache.org/r/15937/#comment58835>

    this should call the actual PackagedWorkflowRepository (since it's a read only operation).



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowResource.java
<https://reviews.apache.org/r/15937/#comment58836>

    would be great to add this read only method to packaged workflow repo in WM.



trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/servlets/WmServicesServlet.java
<https://reviews.apache.org/r/15937/#comment58837>

    seems like at some level, this class shouldn't be needed, and that the config here should
be moved to AbstractWorkflowResource?



trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml
<https://reviews.apache.org/r/15937/#comment58838>

    how about /wmservices?



trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml
<https://reviews.apache.org/r/15937/#comment58840>

    should be [WORKFLOW_URL] and envReplaced.



trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml
<https://reviews.apache.org/r/15937/#comment58839>

    should be replaced with [WORKFLOW_HOME]/policy/wengine, and then inside of AbstractWorkflowResource
should be PathUtils.envReplaced (all read context params)


- Chris Mattmann


On Dec. 1, 2013, 7 p.m., Varun Ratnakar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15937/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2013, 7 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Bugs: OODT-563
>     https://issues.apache.org/jira/browse/OODT-563
> 
> 
> Repository: oodt
> 
> 
> Description
> -------
> 
> This patch addresses the second part of https://issues.apache.org/jira/browse/OODT-563.
It adds a new webapp under webapps/wmservices which provides:
> 1. A servlet with Jax-RS functionality to Add/Remove workflows (just packaged repository
workflows for now)
> 
> 
> Diffs
> -----
> 
>   trunk/webapp/wmservices/pom.xml PRE-CREATION 
>   trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/client/WmServicesClient.java
PRE-CREATION 
>   trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/repository/PackagedWorkflowManager.java
PRE-CREATION 
>   trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/Resource.java
PRE-CREATION 
>   trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/resources/WorkflowResource.java
PRE-CREATION 
>   trunk/webapp/wmservices/src/main/java/org/apache/oodt/cas/wmservices/servlets/WmServicesServlet.java
PRE-CREATION 
>   trunk/webapp/wmservices/src/main/webapp/META-INF/context.xml PRE-CREATION 
>   trunk/webapp/wmservices/src/main/webapp/WEB-INF/web.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15937/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Varun Ratnakar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message