Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B1D6310B99 for ; Thu, 13 Jun 2013 01:54:08 +0000 (UTC) Received: (qmail 39279 invoked by uid 500); 13 Jun 2013 01:54:08 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 39259 invoked by uid 500); 13 Jun 2013 01:54:08 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 7340 invoked by uid 99); 11 Jun 2013 20:39:05 -0000 Content-Type: multipart/alternative; boundary="===============1562066755734228143==" MIME-Version: 1.0 Subject: Review Request: OODT-627 Review From: "Michael Joyce" To: "Cameron Goodale" , "Chris Mattmann" Cc: "oodt" , "Michael Joyce" Date: Tue, 11 Jun 2013 20:38:57 -0000 Message-ID: <20130611203857.3558.83091@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Michael Joyce" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/11810/ X-Sender: "Michael Joyce" Reply-To: "Michael Joyce" --===============1562066755734228143== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11810/ ----------------------------------------------------------- Review request for oodt, Chris Mattmann and Cameron Goodale. Description ------- Please see [1] for a more thorough description. I decided to change the Map= pingFunc calls instead of the actual implementation of ReplaceFunc since I = felt that this made the most sense. The ReplaceFunc implementation seems to= imply the "replace 'orig' with 'with'" approach so I left that alone and c= hanged the various calls. [1] https://issues.apache.org/jira/browse/OODT-627 Diffs ----- /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHand= ler.java 1490420 = /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/profile/DBMSExecutor.jav= a 1490420 = /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1= 490420 = Diff: https://reviews.apache.org/r/11810/diff/ Testing ------- Tested locally with the setup from [1] and changes to the example-ps.xml fi= le from [2]. All tests pass and functionality of product handler is as expe= cted. [1] https://cwiki.apache.org/confluence/display/OODT/XMLPS+Quick+Start+Guide [2] https://issues.apache.org/jira/browse/OODT-627 Thanks, Michael Joyce --===============1562066755734228143==--