oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Joyce" <mltjo...@gmail.com>
Subject Review Request: OODT-627 Review
Date Tue, 11 Jun 2013 20:38:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11810/
-----------------------------------------------------------

Review request for oodt, Chris Mattmann and Cameron Goodale.


Description
-------

Please see [1] for a more thorough description. I decided to change the MappingFunc calls
instead of the actual implementation of ReplaceFunc since I felt that this made the most sense.
The ReplaceFunc implementation seems to imply the "replace 'orig' with 'with'" approach so
I left that alone and changed the various calls.

[1] https://issues.apache.org/jira/browse/OODT-627


Diffs
-----

  /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/product/XMLPSProductHandler.java 1490420

  /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/profile/DBMSExecutor.java 1490420 
  /trunk/xmlps/src/main/java/org/apache/oodt/xmlps/structs/CDEResult.java 1490420 

Diff: https://reviews.apache.org/r/11810/diff/


Testing
-------

Tested locally with the setup from [1] and changes to the example-ps.xml file from [2]. All
tests pass and functionality of product handler is as expected.

[1] https://cwiki.apache.org/confluence/display/OODT/XMLPS+Quick+Start+Guide
[2] https://issues.apache.org/jira/browse/OODT-627


Thanks,

Michael Joyce


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message