oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Native Solr implementation of CAS File Manager
Date Sun, 21 Apr 2013 17:29:25 GMT


> On April 21, 2013, 5:54 a.m., Chris Mattmann wrote:
> > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml,
line 65
> > <https://reviews.apache.org/r/10288/diff/1/?file=277932#file277932line65>
> >
> >     do we really need solr schema as a resource? This would suggest it gets shipped
by default inside of e.g., $FILEMGR_HOME/etc.

I saw later why this is needed. +1 to keeping it as a resource. IOW ignore this comment.


> On April 21, 2013, 5:54 a.m., Chris Mattmann wrote:
> > http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java,
line 43
> > <https://reviews.apache.org/r/10288/diff/1/?file=277935#file277935line43>
> >
> >     I see you've turned this into an interface. Do you expect many people to extend
this? I'm more of a fan of keeping things concrete, until it's needed (e.g., at least 2 implementations)
to make something an interface. Thoughts about this not implementing ProductSerializer, and
removing it as an interface?

This whole interface is a result of having our own SolrClient. I see why it's needed now and
I'm OK with it. See my comment later about SerDe and combining this interface with the other.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10288/#review19508
-----------------------------------------------------------


On April 4, 2013, 8:03 p.m., Luca Cinquini wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10288/
> -----------------------------------------------------------
> 
> (Updated April 4, 2013, 8:03 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Description
> -------
> 
> This Catalog sub-package provides an extensible set of functionality that allows a CAS
File Manager to store and query metadata to/from a standalone Solr server.
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/assembly/assembly.xml 1463907

>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/CompleteProduct.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductDeserializer.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/DefaultProductSerializer.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/NameProductIdGenerator.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/OODT_SOLR_README.TXT
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/Parameters.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductDeserializer.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductIdGenerator.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/ProductSerializer.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QUICK_START_GUIDE.TXT
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/QueryResponse.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalog.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrCatalogFactory.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/SolrClient.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/solr/UUIDProductIdGenerator.java
PRE-CREATION 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/filemgr.properties
1464226 
>   http://svn.apache.org/repos/asf/oodt/trunk/filemgr/src/main/resources/schema.xml PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/10288/diff/
> 
> 
> Testing
> -------
> 
> Tested ingestion and querying of simple products of type 'GenericFile', as well as products
generated by the VFASTR pipeline (but without splitting them in separate documents for Job/Scan/Event
information).
> Included draft documentation for Apache wiki: quick start guide and in-depth architecture
guide.
> 
> 
> Thanks,
> 
> Luca Cinquini
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message