oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Suggested Fix for JIRA Issue OODT-553
Date Sat, 02 Feb 2013 23:14:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9142/#review16042
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Mattmann


On Jan. 29, 2013, 9:25 p.m., Michael Starch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9142/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 9:25 p.m.)
> 
> 
> Review request for oodt and Chris Mattmann.
> 
> 
> Description
> -------
> 
> This is a review for a patch for JIRA issue OODT-553 (https://issues.apache.org/jira/browse/OODT-553).
 It fixes the EnvUtilities. to use System.getEnvironment and not exec "env".
> 
> 
> Diffs
> -----
> 
>   /trunk/commons/src/main/java/org/apache/oodt/commons/exec/EnvUtilities.java 1439711

>   /trunk/commons/src/test/org/apache/oodt/commons/exec/TestEnvUtilities.java 1439711

> 
> Diff: https://reviews.apache.org/r/9142/diff/
> 
> 
> Testing
> -------
> 
> Wrote several new unit tests that test this on unix systems  only as it requires USER
and HOME env vars to be set.
> 
> 
> Thanks,
> 
> Michael Starch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message