oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "brian Foster" <holen...@juno.com>
Subject Re: Review Request: Purposed Changes to Workflow, WorkflowInstance, and WorkflowProcessor
Date Fri, 09 Nov 2012 01:38:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7944/
-----------------------------------------------------------

(Updated Nov. 9, 2012, 1:38 a.m.)


Review request for oodt, Chris Mattmann and Paul Ramirez.


Description
-------

My purposed changes to Workflow, WorkflowInstance, and WorkflowProcessor... a WorkflowInstance
now holds the state of the Workflow and all the Workflow's Tasks and Conditions (Pre and Post)...
A WorkflowProcessor is now just given a WorkflowInstance and is able to just determine what
is the current state of that Workflow and what it's allowed runnables are... A WorkflowProcessor
was change to only handle a single Workflow at a time... Workflows for the WEngine port are
not longer Workflows inside Workflows but Workflows chained together in a Graph... As from
my code in this review i believe this will lead to a cleaner port of WEngine into the trunk
and also better fits the current trunk cas-workflow model.


Diffs (updated)
-----

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuerier.java 1399095

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/ConditionProcessor.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/ParallelProcessor.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/SequentialProcessor.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/StdWorkflowProcessor.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/TaskProcessor.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessor.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorListener.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processor/WorkflowProcessorQueue.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/lifecycle/WorkflowState.java 1399095

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/Graph.java 1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/ParentChildWorkflow.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/PrioritySorter.java 1399095

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RunnableInstance.java
PRE-CREATION 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/Workflow.java 1399095

  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstance.java
1399095 
  trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstanceStub.java
PRE-CREATION 

Diff: https://reviews.apache.org/r/7944/diff/


Testing
-------


Thanks,

brian Foster


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message