oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cinquini, Luca (3880)" <Luca.Cinqu...@jpl.nasa.gov>
Subject Re: svn commit: r1412053 - /oodt/trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java
Date Thu, 22 Nov 2012 11:47:46 GMT
Thanks Chris, comment added. You are right that I should have mentioned the issue number in
the commit.
thanks for the careful review :)
Luca

On Nov 21, 2012, at 5:09 PM, Mattmann, Chris A (388J) wrote:

> Hey Luca,
> 
> Ah, perfect. If it was for OODT-522, then if you ref that in your commit message that
helps to 
> tie to the issue that you are fixing. And it helps people like me who peer review the
commits
> to know that it's for something that you already filed one for :)
> 
> +1 to adding a comment on OODT-522 about what you updated.
> 
> Thanks!
> 
> Cheers,
> Chris
> 
> On Nov 21, 2012, at 3:57 PM, Cinquini, Luca (3880) wrote:
> 
>> Hi Chris,
>> 	sure, but I have a question first: this is really a fix on the following issue,
which got filed and solved a few weeks ago:
>> 
>> https://issues.apache.org/jira/browse/OODT-522
>> 
>> Would it be more appropriate to insert a comment in this Jira issue, bringing its
development to a close ?
>> 
>> thanks, Luca
>> 
>> On Nov 21, 2012, at 10:19 AM, Mattmann, Chris A (388J) wrote:
>> 
>>> Hi Luca,
>>> 
>>> Can you please file a JIRA issue for this? This was a change I believe
>>> that took some time to track down so having it in a JIRA issue will help
>>> others track and understand how it was fixed. It should also appear in
>>> our change log.
>>> 
>>> Thanks!
>>> 
>>> Cheers,
>>> Chris
>>> 
>>> On Nov 21, 2012, at 2:50 AM, <luca@apache.org>
>>> <luca@apache.org> wrote:
>>> 
>>>> Author: luca
>>>> Date: Wed Nov 21 10:50:30 2012
>>>> New Revision: 1412053
>>>> 
>>>> URL: http://svn.apache.org/viewvc?rev=1412053&view=rev
>>>> Log:
>>>> Removing product references upon metadata update, as they will be added again
later on.
>>>> 
>>>> Modified:
>>>> oodt/trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java
>>>> 
>>>> Modified: oodt/trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java
>>>> URL: http://svn.apache.org/viewvc/oodt/trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java?rev=1412053&r1=1412052&r2=1412053&view=diff
>>>> ==============================================================================
>>>> --- oodt/trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java
(original)
>>>> +++ oodt/trunk/curator/src/main/java/org/apache/oodt/cas/curation/service/MetadataResource.java
Wed Nov 21 10:50:30 2012
>>>> @@ -523,6 +523,12 @@ public class MetadataResource extends Cu
>>>>    // retrieve existing metadata
>>>>    metadata = catalog.getMetadata(product);
>>>> 
>>>> +      // remove product references (as they will be added later)
>>>> +      metadata.removeMetadata("reference_orig");
>>>> +      metadata.removeMetadata("reference_data_store");
>>>> +      metadata.removeMetadata("reference_fileSize");
>>>> +      metadata.removeMetadata("reference_mimeType");
>>>> +      
>>>>    // merge new and existing metadata
>>>>    metadata.addMetadata(newMetadata);
>>>> 
>>>> 
>>>> 
>>> 
>> 
> 


Mime
View raw message