Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72C51D1AA for ; Tue, 7 Aug 2012 15:40:44 +0000 (UTC) Received: (qmail 85588 invoked by uid 500); 7 Aug 2012 15:40:44 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 85571 invoked by uid 500); 7 Aug 2012 15:40:44 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 17512 invoked by uid 99); 6 Aug 2012 20:41:24 -0000 Content-Type: multipart/alternative; boundary="===============4560669224381719225==" MIME-Version: 1.0 Subject: Review Request: Factory out EngineRunner and WorkflowProcessor classes into their own packages From: "brian Foster" To: "Paul Ramirez" , "Thomas Bennett" , "Ricky Nguyen" , "Chris Mattmann" Cc: "brian Foster" , "oodt" Date: Mon, 06 Aug 2012 20:41:23 -0000 Message-ID: <20120806204123.5557.12799@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "brian Foster" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/6407/ X-Sender: "brian Foster" Reply-To: "brian Foster" --===============4560669224381719225== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6407/ ----------------------------------------------------------- Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Th= omas Bennett. Description ------- EngineRunner classes will be put into a new package in: org.apache.oodt.cas.workflow.engine.runner WorkflowProcessor classes will be out into a new package in: org.apache.oodt.cas.workflow.engine.processor This will also include two EngineRunnerFactories which where left out of OO= DT-310 patch This addresses bug OODT-485. https://issues.apache.org/jira/browse/OODT-485 Diffs ----- trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Asynchro= nousLocalEngineRunner.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Conditio= nProcessor.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/EngineRu= nner.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/EngineRu= nnerFactory.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Parallel= Processor.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Prioriti= zedQueueBasedWorkflowEngine.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Processo= rDateTimeInfo.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Resource= Runner.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Resource= RunnerFactory.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Sequenti= alProcessor.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Synchron= ousLocalEngineRunner.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskProc= essor.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQuer= ier.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskRunn= er.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/ThreadPo= olWorkflowEngine.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workflow= Engine.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workflow= Processor.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workflow= ProcessorBuilder.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workflow= ProcessorListener.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workflow= ProcessorQueue.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/ConditionProcessor.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/ParallelProcessor.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/ProcessorDateTimeInfo.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/SequentialProcessor.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/TaskProcessor.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/WorkflowProcessor.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/WorkflowProcessorBuilder.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/WorkflowProcessorListener.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/processo= r/WorkflowProcessorQueue.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/A= synchronousLocalEngineRunner.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/A= synchronousLocalEngineRunnerFactory.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/E= ngineRunner.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/E= ngineRunnerFactory.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/R= esourceRunner.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/R= esourceRunnerFactory.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/S= ynchronousLocalEngineRunner.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/runner/S= ynchronousLocalEngineRunnerFactory.java PRE-CREATION = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/FILOPri= oritySorter.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/Highest= FIFOPrioritySorter.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/Highest= PrioritySorter.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/Priorit= ySorter.java 1369913 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWo= rkflowManager.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/GenericWor= kflowObjectFactory.java 1369914 = trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/WorkflowUt= ils.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/MockProcessor= Queue.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/QuerierAndRun= nerUtils.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestAsynchron= ousLocalEngineRunner.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQueri= er.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/structs/TestFILOPrio= ritySorter.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/structs/TestHighestF= IFOPrioritySorter.java 1369913 = trunk/workflow/src/test/org/apache/oodt/cas/workflow/structs/TestHighestP= rioritySorter.java 1369913 = Diff: https://reviews.apache.org/r/6407/diff/ Testing ------- ran unit-tests Thanks, brian Foster --===============4560669224381719225==--