Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8C1DEC459 for ; Sat, 4 Aug 2012 02:42:36 +0000 (UTC) Received: (qmail 39923 invoked by uid 500); 4 Aug 2012 02:42:36 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 39896 invoked by uid 500); 4 Aug 2012 02:42:36 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 20371 invoked by uid 99); 4 Aug 2012 02:32:25 -0000 Content-Type: multipart/alternative; boundary="===============9018985727038601687==" MIME-Version: 1.0 Subject: Re: Review Request: EngineRunnerFactory introduction and Java property cleanup From: "Chris Mattmann" To: "Paul Ramirez" , "Thomas Bennett" , "Ricky Nguyen" , "Chris Mattmann" Cc: "brian Foster" , "oodt" Date: Sat, 04 Aug 2012 02:32:24 -0000 Message-ID: <20120804023224.22301.26181@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Mattmann" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/6357/ X-Sender: "Chris Mattmann" References: <20120803224747.22301.98410@reviews.apache.org> In-Reply-To: <20120803224747.22301.98410@reviews.apache.org> Reply-To: "Chris Mattmann" --===============9018985727038601687== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6357/#review9844 ----------------------------------------------------------- Ship it! LGTM! trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWork= flowManager.java we should change this to 9001 - Chris Mattmann On Aug. 3, 2012, 10:47 p.m., brian Foster wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6357/ > ----------------------------------------------------------- > = > (Updated Aug. 3, 2012, 10:47 p.m.) > = > = > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and = Thomas Bennett. > = > = > Description > ------- > = > Added EngineRunnerFactory interface and implementations > = > = > This addresses bug OODT-310. > https://issues.apache.org/jira/browse/OODT-310 > = > = > Diffs > ----- > = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Engine= Runner.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Engine= RunnerFactory.java PRE-CREATION = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Priori= tizedQueueBasedWorkflowEngine.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Resour= ceRunnerFactory.java PRE-CREATION = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Thread= PoolWorkflowEngine.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Thread= PoolWorkflowEngineFactory.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workfl= owEngine.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workfl= owEngineFactory.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpc= WorkflowManager.java 1369233 = > trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/GenericW= orkflowObjectFactory.java 1369233 = > = > Diff: https://reviews.apache.org/r/6357/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > brian Foster > = > --===============9018985727038601687==--