-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6416/#review9962
-----------------------------------------------------------
Ship it!
LGTM.
- Chris Mattmann
On Aug. 7, 2012, 3:36 a.m., Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6416/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2012, 3:36 a.m.)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and
Thomas Bennett.
>
>
> Description
> -------
>
> TestXmlRpcWorkflowManager JUnit was not passing. When I tried running the wmgr (./wmgr)
the following exception was thrown:
> Exception in thread "main" java.lang.ClassCastException: org.apache.oodt.cas.workflow.engine.SynchronousLocalEngineRunner
cannot be cast to org.apache.oodt.cas.workflow.engine.EngineRunnerFactory
> at org.apache.oodt.cas.workflow.util.GenericWorkflowObjectFactory.getEngineRunnerFromClassName(GenericWorkflowObjectFactory.java:82)
> at org.apache.oodt.cas.workflow.system.XmlRpcWorkflowManager.getEngineRunnerFromProperty(XmlRpcWorkflowManager.java:636)
> at org.apache.oodt.cas.workflow.system.XmlRpcWorkflowManager.<init>(XmlRpcWorkflowManager.java:96)
> at org.apache.oodt.cas.workflow.system.XmlRpcWorkflowManager.main(XmlRpcWorkflowManager.java:609)
>
>
> This addresses bug OODT-310.
> https://issues.apache.org/jira/browse/OODT-310
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/AsynchronousLocalEngineRunnerFactory.java
PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/SynchronousLocalEngineRunner.java
1370102
> http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/SynchronousLocalEngineRunnerFactory.java
PRE-CREATION
> http://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java
1370102
>
> Diff: https://reviews.apache.org/r/6416/diff/
>
>
> Testing
> -------
>
> TestXmlRpcWorkflowManager JUnit test pass. Also able to kick off wmgr with no exceptions.
>
>
> Thanks,
>
> Sheryl John
>
>
|