oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: RemoteSiteFile doesn't always set RemoteSite
Date Fri, 27 Jul 2012 04:32:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6166/#review9526
-----------------------------------------------------------


I think we need to add the pom.xml dep update for the Google Preconditions code. LGTM after
that.

- Chris Mattmann


On July 27, 2012, 12:15 a.m., brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6166/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 12:15 a.m.)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Description
> -------
> 
> Causes NullPointerException:
> SEVERE: Failed to finish downloading per property files
> /home/yhkang/oodt/cas-pushpull/etc/examples/DirStructXmlParserFiles/RTG_SST.xml
> : null
> java.lang.NullPointerException
> at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.validate(FileRetrievalSystem.java:367)
> at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:311)
> at org.apache.oodt.cas.pushpull.retrievalsystem.FileRetrievalSystem.changeToDir(FileRetrievalSystem.java:300)
> at org.apache.oodt.cas.pushpull.retrievalmethod.RemoteCrawler.processPropFile(RemoteCrawler.java:103)
> at org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.retrieveFiles(RetrievalSetup.java:109)
> at org.apache.oodt.cas.pushpull.daemon.Daemon$1.run(Daemon.java:218)
> at java.lang.Thread.run(Thread.java:662)
> 
> 
> This addresses bug OODT-476.
>     https://issues.apache.org/jira/browse/OODT-476
> 
> 
> Diffs
> -----
> 
>   trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java
1365306 
>   trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/RemoteSiteFile.java
1365306 
>   trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalmethod/RemoteCrawler.java
1365306 
>   trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/FileRetrievalSystem.java
1365306 
>   trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/retrievalsystem/RetrievalSetup.java
1365306 
> 
> Diff: https://reviews.apache.org/r/6166/diff/
> 
> 
> Testing
> -------
> 
> Ran test provided by YunHee
> 
> 
> Thanks,
> 
> brian Foster
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message