Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 58E9F95CC for ; Sun, 24 Jun 2012 08:15:34 +0000 (UTC) Received: (qmail 12297 invoked by uid 500); 24 Jun 2012 08:15:33 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 12203 invoked by uid 500); 24 Jun 2012 08:15:32 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Delivered-To: moderator for dev@oodt.apache.org Received: (qmail 50402 invoked by uid 99); 24 Jun 2012 07:36:42 -0000 Content-Type: multipart/alternative; boundary="===============7024785327735002074==" MIME-Version: 1.0 Subject: Re: Review Request: Change SciPgeConfigFileWriter to DynamicConfigFileWriter From: "Chris Mattmann" To: "Paul Ramirez" , "Thomas Bennett" , "Ricky Nguyen" , "Chris Mattmann" Cc: "brian Foster" , "oodt" Date: Sun, 24 Jun 2012 07:36:41 -0000 Message-ID: <20120624073641.10353.241@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Chris Mattmann" X-ReviewGroup: oodt X-ReviewRequest-URL: https://reviews.apache.org/r/5428/ X-Sender: "Chris Mattmann" References: <20120620010040.28905.69476@reviews.apache.org> In-Reply-To: <20120620010040.28905.69476@reviews.apache.org> Reply-To: "Chris Mattmann" --===============7024785327735002074== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5428/#review8514 ----------------------------------------------------------- Ship it! Ship It! - Chris Mattmann On June 20, 2012, 1 a.m., brian Foster wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5428/ > ----------------------------------------------------------- > = > (Updated June 20, 2012, 1 a.m.) > = > = > Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and = Thomas Bennett. > = > = > Description > ------- > = > I figure this is a good time to change the name of this interface, which = was poorly named, since cas-pge has taken a huge overhaulin... Logger is be= ing added to the method arguments and the method name is being changed: > = > public File generateFile(String filePath, Metadata metadata, Logger logge= r, > Object... args) throws Exception; > = > = > This addresses bug OODT-467. > https://issues.apache.org/jira/browse/OODT-467 > = > = > Diffs > ----- > = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 13= 51904 = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFa= ctory.java 1351904 = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/CsvConfigFileWr= iter.java 1351905 = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/DynamicConfigFi= leWriter.java PRE-CREATION = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/SciPgeConfigFil= eWriter.java 1351904 = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/TextConfigFileW= riter.java 1351905 = > trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/XslTransformWri= ter.java 1351905 = > trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 135= 1905 = > trunk/pge/src/test/org/apache/oodt/cas/pge/writers/MockDynamicConfigFil= eWriter.java PRE-CREATION = > trunk/pge/src/test/org/apache/oodt/cas/pge/writers/MockSciPgeConfigFile= Writer.java 1351904 = > = > Diff: https://reviews.apache.org/r/5428/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > brian Foster > = > --===============7024785327735002074==--