oodt-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Mattmann" <mattm...@apache.org>
Subject Re: Review Request: Change SciPgeConfigFileWriter to DynamicConfigFileWriter
Date Sun, 24 Jun 2012 07:36:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5428/#review8514
-----------------------------------------------------------

Ship it!


Ship It!

- Chris Mattmann


On June 20, 2012, 1 a.m., brian Foster wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5428/
> -----------------------------------------------------------
> 
> (Updated June 20, 2012, 1 a.m.)
> 
> 
> Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
> 
> 
> Description
> -------
> 
> I figure this is a good time to change the name of this interface, which was poorly named,
since cas-pge has taken a huge overhaulin... Logger is being added to the method arguments
and the method name is being changed:
> 
> public File generateFile(String filePath, Metadata metadata, Logger logger,
>          Object... args) throws Exception;
> 
> 
> This addresses bug OODT-467.
>     https://issues.apache.org/jira/browse/OODT-467
> 
> 
> Diffs
> -----
> 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/PGETaskInstance.java 1351904 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/util/GenericPgeObjectFactory.java 1351904

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/CsvConfigFileWriter.java 1351905

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/DynamicConfigFileWriter.java
PRE-CREATION 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/SciPgeConfigFileWriter.java
1351904 
>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/TextConfigFileWriter.java 1351905

>   trunk/pge/src/main/java/org/apache/oodt/cas/pge/writers/XslTransformWriter.java 1351905

>   trunk/pge/src/test/org/apache/oodt/cas/pge/TestPGETaskInstance.java 1351905 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/writers/MockDynamicConfigFileWriter.java
PRE-CREATION 
>   trunk/pge/src/test/org/apache/oodt/cas/pge/writers/MockSciPgeConfigFileWriter.java
1351904 
> 
> Diff: https://reviews.apache.org/r/5428/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> brian Foster
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message