Return-Path: X-Original-To: apmail-oodt-dev-archive@www.apache.org Delivered-To: apmail-oodt-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C37CB924C for ; Sun, 27 May 2012 21:58:04 +0000 (UTC) Received: (qmail 24593 invoked by uid 500); 27 May 2012 21:58:04 -0000 Delivered-To: apmail-oodt-dev-archive@oodt.apache.org Received: (qmail 24505 invoked by uid 500); 27 May 2012 21:58:03 -0000 Mailing-List: contact dev-help@oodt.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@oodt.apache.org Delivered-To: mailing list dev@oodt.apache.org Received: (qmail 24472 invoked by uid 99); 27 May 2012 21:58:03 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 May 2012 21:58:03 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 86AEC1C0833; Sun, 27 May 2012 21:58:01 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0936114740642803750==" MIME-Version: 1.0 Subject: Re: Review Request: Wengine Task Querier Thread: OODT-310 From: "Chris Mattmann" To: "Paul Ramirez" , "brian Foster" , "Sheryl John" , "Ricky Nguyen" , "Thomas Bennett" Date: Sun, 27 May 2012 21:58:01 -0000 Message-ID: <20120527215801.22577.89638@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/4961/ Cc: "Chris Mattmann" ,"oodt" In-Reply-To: <20120527053555.14920.89465@reviews.apache.org> References: <20120527053555.14920.89465@reviews.apache.org> --===============0936114740642803750== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4961/ ----------------------------------------------------------- (Updated 2012-05-27 21:58:01.392196) Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl J= ohn, and Thomas Bennett. Changes ------- Updated unit test, and changed the locking/synchronization logic. All unit = tests pass and I think this is good to go. I'll commit it tonight or tomorr= ow. Thanks all for the review! Summary ------- Task Querier thread for OODT-310. See javadocs on: https://builds.apache.or= g/job/oodt-trunk/javadoc/org/apache/oodt/cas/workflow/engine/TaskQuerier.ht= ml This addresses bug OODT-310. https://issues.apache.org/jira/browse/OODT-310 Diffs (updated) ----- ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Parall= elProcessor.java 1342993 = ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Sequen= tialProcessor.java 1342993 = ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskPr= ocessor.java 1342993 = ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/TaskQu= erier.java 1342993 = ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workfl= owProcessor.java 1342993 = ./trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/engine/Workfl= owProcessorBuilder.java PRE-CREATION = ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQue= rier.java PRE-CREATION = Diff: https://reviews.apache.org/r/4961/diff Testing ------- Includes unit test, that currently isn't passing. I think I know why (somet= hing up with my threading logic and synchronized keywords) but wanted to th= row it up for review. I'll likely be working on this tomorrow or the follow= ing evening. Thanks, Chris --===============0936114740642803750==--